The gui doesn't handle exceptions very well #18643

issue MarcoFalke opened this issue on April 15, 2020

MarcoFalke commented at 1:17 AM on April 15, 2020: member

The GUI crashes on exceptions such as NonFatalCheckError. I think it is more user friendly for a GUI to catch the exception and display it to the user, then abort the current action and leave the main window running.

I tested this by mutating the conditional in a CHECK_NONFATAL.

$ ./src/qt/bitcoin-qt 
QSocketNotifier: Can only be used with threads started with QThread


************************
EXCEPTION: 18NonFatalCheckError       
wallet/wallet.cpp:2636 (IsCurrentForAntiFeeSniping)
Internal bug detected: '!chain.findBlock(block_hash, FoundBlock().time(block_time))'
You may report this issue here: https://github.com/bitcoin/bitcoin/issues
       
bitcoin in Runaway exception       

terminate called after throwing an instance of 'NonFatalCheckError'
  what():  wallet/wallet.cpp:2636 (IsCurrentForAntiFeeSniping)
Internal bug detected: '!chain.findBlock(block_hash, FoundBlock().time(block_time))'
You may report this issue here: https://github.com/bitcoin/bitcoin/issues

Aborted (core dumped)

Screenshot from 2020-04-14 21-11-32

MarcoFalke added the label Bug on Apr 15, 2020
MarcoFalke commented at 1:18 AM on April 15, 2020: member

The RPC currently handles them nicely, by wrapping any exception into an JSONRPCError and returning from the call gracefully.
MarcoFalke commented at 1:19 AM on April 15, 2020: member

And unrelated: "Bitcoin can no longer continue safely" sounds interesting, but should probably be replaced by PACKAGE_NAME
fanquake added the label GUI on Apr 15, 2020
fanquake cross-referenced this on Apr 15, 2020 from issue gui: use PACKAGE_NAME in exception message by fanquake
MarcoFalke referenced this in commit 18f11fb24b on Apr 15, 2020
hebasto cross-referenced this on May 6, 2020 from issue qt: Handle exceptions instead of crash by hebasto
hebasto commented at 12:04 PM on May 6, 2020: member

@MarcoFalke Mind looking into #18897?
hebasto cross-referenced this on May 6, 2020 from issue gui: Display warnings as rich text by hebasto
instagibbs commented at 6:41 PM on May 9, 2020: member

Seems related: #18924
ComputerCraftr referenced this in commit b8579c56cd on Jun 10, 2020
fanquake cross-referenced this on Sep 15, 2020 from issue The gui doesn't handle exceptions very well by fanquake
fanquake commented at 8:37 AM on September 15, 2020: member

Moved to https://github.com/bitcoin-core/gui/issues/91.
fanquake closed this on Sep 15, 2020
hebasto cross-referenced this on Mar 27, 2021 from issue Handle exceptions instead of crash by hebasto
laanwj referenced this in commit 03ecceedf6 on Apr 14, 2021
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#18646 gui: use PACKAGE_NAME in exception message #18897 qt: Handle exceptions instead of crash #18898 gui: Display warnings as rich text #18924 QT Crash when using open wallet dialog