Fix naming of macOS SDK and clarify version #18589

1. 
   achow101 commented at 12:16 AM on April 11, 2020: member

   Fixes the MacOSX10.14.sdk.tar.gz creation command to have MacOSX.sdk be correctly named as MacOSX10.14.sdk and for the resulting file to be placed in the current directory. Gitian requires that tar.gz contains a folder named MacOSX10.14.sdk and the command did not do this originally. Having the file be placed in the current directory is a convenience so builders don't have to go find it.

   Also clarifies which version of Xcode to download and where it can be downloaded.

2. fanquake added the label Docs on Apr 11, 2020
3. 
   DrahtBot commented at 4:03 AM on April 11, 2020: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18072 (Use libc++ headers from macOS SDK instead of from clang by dongcarl)
   • #17919 (depends: Allow building with system clang by dongcarl)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot cross-referenced this on Apr 11, 2020 from issue Use `libc++` headers from macOS SDK instead of from clang by dongcarl
5. DrahtBot cross-referenced this on Apr 11, 2020 from issue depends: Allow building with system clang by dongcarl
6. 
   Emzy commented at 12:41 PM on April 11, 2020: contributor

   Approach ACK It fixed my gitian build setup.

7. fanquake requested review from dongcarl on Apr 12, 2020
8. 
   Sjors commented at 2:18 PM on April 19, 2020: member

   See also #18674

9. 
   Sjors commented at 6:26 PM on April 19, 2020: member

   On macOS the equivalent is tar -s "/MacOSX.sdk/MacOSX10.14.sdk/"

10. 
    achow101 commented at 10:03 PM on April 21, 2020: member

    @Sjors Was that the exact command you used? I can update the doc with what actually worked.

11. 
    Sjors commented at 7:46 AM on April 23, 2020: member

    tar -s "/MacOSX.sdk/MacOSX10.14.sdk/" -C Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/ -czf MacOSX10.14.sdk.tar.gz MacOSX.sdk
    

12. fanquake added the label Needs backport (0.20) on Apr 23, 2020
13. Fix naming of macOS SDK and clarify version eb37275a6f
14. achow101 force-pushed on Apr 23, 2020
15. 
    Sjors commented at 6:51 PM on April 23, 2020: member

    ACK eb37275 for the macOS instruction

16. fanquake approved
17. 
    fanquake commented at 9:22 AM on April 24, 2020: member

    ACK eb37275a6f972c81caef010b4ee9c5dc88edc759 - tested the macOS and Linux SDK extraction. Also noticed something seemingly broken with Apple tar, but will open an issue to follow up.

18. fanquake merged this on Apr 24, 2020
19. fanquake closed this on Apr 24, 2020

    ---

20. fanquake referenced this in commit a9ca65bd29 on Apr 24, 2020
21. fanquake cross-referenced this on Apr 24, 2020 from issue [0.20] rc2 Backports by fanquake
22. fanquake removed the label Needs backport (0.20) on Apr 24, 2020
23. laanwj referenced this in commit fb5b098598 on May 11, 2020
24. str4d cross-referenced this on Jul 30, 2020 from issue Modernise macOS cross-compilation toolchain by str4d
25. zkbot referenced this in commit 2a39656e6d on Jul 30, 2020
26. zkbot referenced this in commit e0692ed4df on Aug 7, 2020
27. Fuzzbawls cross-referenced this on Mar 26, 2021 from issue [Depends] Update macOS cross-compiling toolchain by Fuzzbawls
28. backpacker69 referenced this in commit f539dadfe3 on Mar 28, 2021
29. furszy referenced this in commit 816f42d7ac on May 25, 2021
30. lyricidal cross-referenced this on Oct 31, 2021 from issue [Upstream] [Depends] Update macOS cross-compiling toolchain by lyricidal
31. bitcoin locked this on Feb 15, 2022

Contributors

achow101DrahtBotEmzySjorsfanquake

Review Requested
dongcarl