test: use zero-argument super() shortcut (Python 3.0+) #18585

pull theStack wants to merge 1 commits into bitcoin:master from theStack:20201004-test-use-python3-non-zero-arg-super changing 3 files +9 −9
  1. theStack commented at 3:48 PM on April 10, 2020: contributor

    This mini-PR replaces all calls to super(...) with arguments with the zero-argument shortcut super() where applicable. See PEP 3135:

    The new syntax:

    super()

    is equivalent to:

    super(__class__, <firstarg>)

    where class is the class that the method was defined in, and <firstarg> is the first parameter of the method (normally self for instance methods, and cls for class methods).

  2. DrahtBot added the label Tests on Apr 10, 2020
  3. DrahtBot cross-referenced this on Apr 22, 2020 from issue test: Remove unused, undocumented and misleading CScript.__add__ by MarcoFalke
  4. DrahtBot commented at 9:03 PM on April 22, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18732 (test: Remove unused, undocumented and misleading CScript.add by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. DrahtBot added the label Needs rebase on Apr 22, 2020
  6. fanquake commented at 11:21 AM on April 25, 2020: member

    Concept ACK

  7. test: use zero-argument super() shortcut (Python 3.0+)
    as defined in PEP 3135:
    
    "The new syntax:
    
        super()
    
    is equivalent to:
    
        super(__class__, <firstarg>)
    
    where __class__ is the class that the method was defined in, and <firstarg> is
    the first parameter of the method (normally self for instance methods, and cls
    for class methods)."
    0956e46bff
  8. theStack force-pushed on Apr 25, 2020
  9. theStack commented at 11:50 AM on April 25, 2020: contributor

    Rebased.

  10. DrahtBot removed the label Needs rebase on Apr 25, 2020
  11. fanquake approved
  12. fanquake commented at 1:14 PM on April 25, 2020: member

    ACK 0956e46bff7f0b6da65a4de6d4f8261fe9d7055c

  13. MarcoFalke merged this on Apr 25, 2020
  14. MarcoFalke closed this on Apr 25, 2020

  15. theStack deleted the branch on Dec 1, 2020
  16. Fabcien referenced this in commit 438dca9e50 on Jan 21, 2021
  17. bitcoin locked this on Feb 15, 2022
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC