fuzz: Disable debug log file #18571

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:2004-testLogExtraArgs changing 10 files +55 −15
  1. MarcoFalke commented at 11:52 PM on April 8, 2020: member

    There are several issues with writing to a debug log file when fuzzing:

    • Disk access is slow, but fuzzing should be fast (Note: I could not verify this claim with data)
    • Disks have a limited size and will eventually run out of space, but fuzzing should run continuous

    Fix both issues by disabling the debug log file for fuzz tests

  2. fanquake added the label Tests on Apr 8, 2020
  3. DrahtBot commented at 5:54 AM on April 9, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18470 (net: Make stale tip check time type-safe, extend test by MarcoFalke)
    • #18077 (net: Add NAT-PMP port forwarding support by hebasto)
    • #17434 (Move parsing from init.cpp to where values are needed by Xekyo)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot cross-referenced this on Apr 9, 2020 from issue build: Drop bitcoin-tx and bitcoin-wallet dependencies on libevent by ryanofsky
  5. DrahtBot cross-referenced this on Apr 9, 2020 from issue test: Extend stale tip test by MarcoFalke
  6. DrahtBot cross-referenced this on Apr 9, 2020 from issue WIP NOMERGE [bench] gitian builds for OP_IF bench by MarcoFalke
  7. DrahtBot cross-referenced this on Apr 9, 2020 from issue Replace current benchmarking framework with nanobench by martinus
  8. DrahtBot cross-referenced this on Apr 9, 2020 from issue Move parsing from init.cpp to where values are needed by murchandamus
  9. DrahtBot added the label Needs rebase on Apr 10, 2020
  10. MarcoFalke force-pushed on Apr 11, 2020
  11. DrahtBot removed the label Needs rebase on Apr 11, 2020
  12. DrahtBot cross-referenced this on Apr 11, 2020 from issue net: Add NAT-PMP port forwarding support by hebasto
  13. MarcoFalke force-pushed on Apr 13, 2020
  14. practicalswift commented at 5:16 PM on April 13, 2020: contributor

    Concept ACK

    Thanks for doing this: faster fuzzing is better fuzzing.

  15. MarcoFalke force-pushed on Apr 15, 2020
  16. node: Add args alias for gArgs global fad4fa7e2f
  17. MarcoFalke force-pushed on Apr 15, 2020
  18. MarcoFalke commented at 7:06 PM on April 15, 2020: member

    Rebased now that #18615 is merged

  19. test: Add optional extra_args to testing setup fa0cbd48c4
  20. fuzz: Disable debug log file fa69f88486
  21. MarcoFalke force-pushed on Apr 15, 2020
  22. practicalswift commented at 7:39 PM on April 15, 2020: contributor

    ACK fa69f88486e900aacf3fc768671f947927173226 -- patch looks correct

  23. MarcoFalke commented at 7:40 PM on April 15, 2020: member

    I couldn't verify my claim that this speeds up fuzzing, but at least I am no longer running out of disk space, so I think it is still required.

  24. MarcoFalke merged this on Apr 15, 2020
  25. MarcoFalke closed this on Apr 15, 2020
  26. MarcoFalke deleted the branch on Apr 15, 2020
  27. ryanofsky cross-referenced this on Jun 4, 2020 from issue Multiprocess bitcoin by ryanofsky
  28. deadalnix referenced this in commit 90aaf20e54 on Jun 29, 2020
  29. Fabcien referenced this in commit 9461ad6e62 on Dec 9, 2020
  30. bitcoin locked this on Feb 15, 2022
Contributors
MarcoFalkeDrahtBotpracticalswift
Labels
Tests
Linked (view graph)
#10102 Multiprocess bitcoin#18615 test: Avoid accessing free'd memory in validation_chainstatemanager_tests
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC