test: Fix unregister_all_during_call cleanup #18563

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/valfix changing 1 files +2 −5

ryanofsky commented at 2:18 PM on April 8, 2020: contributor

Use TestingSetup fixture to fix unregister_all_during_call test not calling UnregisterBackgroundSignalScheduler, which could trigger an assert in RegisterBackgroundSignalScheduler when called in later tests

Failure reported by fanquake #18551 (comment)

Fix unregister_all_during_call cleanup

Use TestingSetup fixture to fix unregister_all_during_call test not calling
UnregisterBackgroundSignalScheduler, which could trigger an assert in
RegisterBackgroundSignalScheduler when called in later tests

Failure reported by fanquake <fanquake@gmail.com>
https://github.com/bitcoin/bitcoin/pull/18551#issuecomment-610974251

13d2a33537

ryanofsky cross-referenced this on Apr 8, 2020 from issue Do not clear validationinterface entries being executed by sipa
MarcoFalke commented at 2:26 PM on April 8, 2020: member

ACK 13d2a33537a403ac47a989be92109d3214375b6a if appveyor unit tests pass
fanquake added the label Tests on Apr 8, 2020
MarcoFalke merged this on Apr 8, 2020
MarcoFalke closed this on Apr 8, 2020
deadalnix referenced this in commit 6f74431345 on Jun 20, 2020
bitcoin locked this on Feb 15, 2022

Contributors

ryanofsky

MarcoFalke

Labels

Tests

Linked (view graph)

#18551 Do not clear validationinterface entries being executed