qa: Test shared validation interface #18471

pull promag wants to merge 2 commits into bitcoin:master from promag:2020-03-test-shared-validation-interface changing 2 files +65 −2
  1. promag commented at 4:40 PM on March 30, 2020: member

    Based on #18338, only last commit matters. Quoting the test description:

    // Test UnregisterSharedValidationInterface ensuring that if interface is
// unregistered during the middle of a callback, interface is destroyed as soon
// as callback returns.

    All credits to ryanofsky.

  2. promag commented at 4:42 PM on March 30, 2020: member

    Initially this was in #18338, decided to push a new PR because some travis job hanged.

  3. DrahtBot added the label GUI on Mar 30, 2020
  4. DrahtBot added the label Tests on Mar 30, 2020
  5. DrahtBot added the label Validation on Mar 30, 2020
  6. DrahtBot added the label Wallet on Mar 30, 2020
  7. DrahtBot commented at 6:34 PM on March 30, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18780 (validation: add const for minimum witness commitment size by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. DrahtBot cross-referenced this on Mar 30, 2020 from issue Build: Move wallet RPCs to their own libbitcoin_walletrpcs module by luke-jr
  9. DrahtBot cross-referenced this on Mar 30, 2020 from issue Use shared pointers only in validation interface by bvbfan
  10. DrahtBot cross-referenced this on Mar 30, 2020 from issue Replace -upgradewallet startup option with upgradewallet RPC by achow101
  11. DrahtBot cross-referenced this on Mar 30, 2020 from issue Multiprocess bitcoin by ryanofsky
  12. ryanofsky referenced this in commit ba8312c7dc on Apr 4, 2020
  13. ryanofsky cross-referenced this on Apr 4, 2020 from issue refactor: drop boost::signals2 in validationinterface by ryanofsky
  14. ryanofsky referenced this in commit ad067a98ea on Apr 4, 2020
  15. ryanofsky referenced this in commit 01639a21d1 on Apr 4, 2020
  16. ryanofsky referenced this in commit 3d463addfe on Apr 4, 2020
  17. ryanofsky referenced this in commit b5fea244e5 on Apr 5, 2020
  18. ryanofsky referenced this in commit c3a471604b on Apr 6, 2020
  19. ryanofsky referenced this in commit 96176004a3 on Apr 6, 2020
  20. ryanofsky referenced this in commit d6815a2313 on Apr 6, 2020
  21. laanwj referenced this in commit fdeb445a34 on Apr 6, 2020
  22. ryanofsky commented at 3:34 PM on April 6, 2020: contributor

    I think #18524 (now merged) might fix the xenial test hang: https://travis-ci.org/github/bitcoin/bitcoin/jobs/668847707

  23. MarcoFalke closed this on Apr 6, 2020
  24. MarcoFalke reopened this on Apr 6, 2020
  25. MarcoFalke removed the label GUI on Apr 6, 2020
  26. Do not clear validationinterface entries being executed
    The previous code for MainSignalsInstance::Clear would decrement the reference
count of every interface, including ones that were already Unregister()ed but
still being executed.
    c182fd517d
  27. Add RegisterSharedValidationInterface test c976165cdf
  28. promag force-pushed on Apr 7, 2020
  29. promag commented at 9:44 AM on April 7, 2020: member

    Now based on #18551, applied the following change to the test to account for @sipa fix (this now fails in master):

    @@ -397,6 +397,7 @@ BOOST_AUTO_TEST_CASE(release_shared)
     BOOST_CHECK(!test_interface);
     BOOST_CHECK_EQUAL(state, CALLED);
     state = UNREGISTERED;
+    UnregisterAllValidationInterfaces();
     unregistered.set_value(true);
     BOOST_CHECK(destroyed.get_future().get());
     BOOST_CHECK_EQUAL(state, DESTROYED);
  30. promag cross-referenced this on Apr 7, 2020 from issue Do not clear validationinterface entries being executed by sipa
  31. promag commented at 11:33 AM on April 7, 2020: member

    appveyor failed with OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted, restarted.

  32. promag commented at 12:13 PM on April 7, 2020: member

    Please set milestone 0.20

  33. sidhujag referenced this in commit 9e2b04c4ed on Apr 8, 2020
  34. glozow referenced this in commit 4542d48e6d on Apr 10, 2020
  35. HashUnlimited referenced this in commit b67fc6bde0 on Apr 17, 2020
  36. DrahtBot cross-referenced this on Apr 27, 2020 from issue validation: add const for minimum witness commitment size by fanquake
  37. MarcoFalke added the label Needs rebase on Apr 27, 2020
  38. MarcoFalke added the label Waiting for author on Apr 27, 2020
  39. DrahtBot removed the label Needs rebase on Apr 27, 2020
  40. MarcoFalke removed the label Validation on Apr 29, 2020
  41. MarcoFalke removed the label Waiting for author on Apr 29, 2020
  42. MarcoFalke removed the label Wallet on Apr 29, 2020
  43. MarcoFalke added the label Waiting for author on Apr 29, 2020
  44. DrahtBot added the label Needs rebase on Apr 30, 2020
  45. DrahtBot commented at 2:03 PM on April 30, 2020: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

  46. deadalnix referenced this in commit 27fc048869 on Jun 20, 2020
  47. metalicjames referenced this in commit 09af10dec5 on Aug 5, 2020
  48. janus referenced this in commit 400926d149 on Nov 5, 2020
  49. backpacker69 referenced this in commit 23b252ddaf on Mar 28, 2021
  50. fanquake commented at 6:26 AM on April 8, 2021: member

    @promag are you still interested in working on / making this change?

  51. MarcoFalke removed the label Waiting for author on Apr 8, 2021
  52. DrahtBot commented at 11:22 AM on December 15, 2021: contributor

    <!--13523179cfe9479db18ec6c5d236f789-->There hasn't been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
  53. DrahtBot commented at 1:07 PM on March 21, 2022: contributor

    <!--13523179cfe9479db18ec6c5d236f789-->There hasn't been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
  54. MarcoFalke added the label Up for grabs on Mar 21, 2022
  55. vijaydasmp referenced this in commit ad85246dda on Apr 5, 2022
  56. vijaydasmp cross-referenced this on Apr 5, 2022 from issue backport: merge bitcoin #16688 by vijaydasmp
  57. fanquake closed this on Apr 26, 2022
  58. vijaydasmp referenced this in commit bff629c6fb on May 19, 2022
  59. vijaydasmp referenced this in commit c6add94995 on May 26, 2022
  60. vijaydasmp referenced this in commit 5cdbd3090e on Jun 14, 2022
  61. vijaydasmp referenced this in commit 5a3418e1fc on Jun 20, 2022
  62. vijaydasmp referenced this in commit 88fe235bc7 on Jun 22, 2022
  63. bitcoin locked this on Apr 26, 2023
Contributors
promagDrahtBotryanofskyfanquake
Labels
TestsUp for grabsNeeds rebase
Linked (view graph)
#15847 Feedback for GitHub CEO#18338 Fix wallet unload race condition#18524 refactor: drop boost::signals2 in validationinterface#18551 Do not clear validationinterface entries being executed
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC