This line from 999931cf8f1 appears to be extraneous and replaced 2 lines after by UniValue balances{UniValue::VOBJ};.
rpc: remove unused getbalances() code #18459
pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:rm-unused-rpcwallet-code changing 1 files +0 −2-
jonatack commented at 7:37 PM on March 28, 2020: contributor
-
rpc: remove unused getbalances() code 6e0d82c55b
-
Empact commented at 7:54 PM on March 28, 2020: member
-
DrahtBot commented at 8:12 PM on March 28, 2020: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #18354 (Protect wallet by using shared pointers by bvbfan)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- hebasto approved
-
hebasto commented at 8:31 PM on March 28, 2020: member
ACK 6e0d82c55bf4a9aae98c47b7cd00b2828b5dd0ee, the
objlocal variable is not used until the end of the scope. - DrahtBot added the label RPC/REST/ZMQ on Mar 28, 2020
- DrahtBot added the label Wallet on Mar 28, 2020
- DrahtBot cross-referenced this on Mar 28, 2020 from issue Use shared pointers only in validation interface by bvbfan
- MarcoFalke merged this on Mar 28, 2020
- MarcoFalke closed this on Mar 28, 2020
- jonatack deleted the branch on Mar 28, 2020
- MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
- MarkLTZ referenced this in commit 1bf4237e04 on Apr 19, 2020
- Fabcien referenced this in commit 989ce58047 on Jan 13, 2021
- bitcoin locked this on Feb 15, 2022
