init: Remove boost::thread_group #18337

pull MarcoFalke wants to merge 4 commits into bitcoin:master from MarcoFalke:2003-NoBoostThreadGroup changing 14 files +135 −86

MarcoFalke commented at 10:46 PM on March 12, 2020: member

This removes boost::thread* where possible. We still need boost::thread for the checkqueue, but ripping it out there should now be a smaller diff.

wallet: Remove unused boost thread include

This was used for the thread_interrupted exception. However, the only
thread that is interruptible is the checkqueue thread. And that thread
does not run the wallet.

fa754cb0e5

scheduler: Switch to std::thread

The scheduler switched to std::condition_variable in commit
d0ebd93270758ea97ea956b8821e17a2d001ea94 and it thus no longer
interruptible. All call sites can be updated to use std::thread

fa9bfef234

MarcoFalke added the label Refactoring on Mar 12, 2020
MarcoFalke added this to the "In progress" column in a project

practicalswift commented at 11:15 PM on March 12, 2020: contributor

Concept ACK: less boost is more
DrahtBot commented at 11:20 PM on March 12, 2020: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #18289 (refactor: Make scheduler methods type safe by MarcoFalke)
- #18011 (Replace current benchmarking framework with nanobench by martinus)
- #16127 (More thread safety annotation coverage by ajtowns)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot cross-referenced this on Mar 12, 2020 from issue refactor: Make scheduler methods type safe by MarcoFalke
init: Remove boost::thread_group fa9f29e08e
MarcoFalke force-pushed on Mar 12, 2020
test: Remove boost::thread_group fa02ce0a36
MarcoFalke force-pushed on Mar 12, 2020
DrahtBot cross-referenced this on Mar 13, 2020 from issue Replace current benchmarking framework with nanobench by martinus
DrahtBot cross-referenced this on Mar 13, 2020 from issue More thread safety annotation coverage by ajtowns
MarcoFalke commented at 2:01 AM on March 13, 2020: member

Closing for now. Will reopen later.
MarcoFalke closed this on Mar 13, 2020
MarcoFalke deleted the branch on Mar 13, 2020
MarcoFalke moved this from the "In progress" to the "Later" column in a project

bitcoin locked this on Feb 15, 2022

Contributors

Labels

init: Remove boost::thread_group #18337

Conflicts