test: add logging to wallet_listsinceblock.py #18306

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:listsinceblock-logging changing 1 files +8 −2

jonatack commented at 7:52 PM on March 9, 2020: contributor

This is the first commit from #17535.

in test/functional/wallet_listsinceblock.py:116 in a3ad519ac6 outdated

 112 | @@ -110,7 +113,7 @@ def test_reorg(self):
 113 |          # generate on both sides
 114 |          lastblockhash = self.nodes[1].generate(6)[5]
 115 |          self.nodes[2].generate(7)
 116 | -        self.log.info('lastblockhash=%s' % (lastblockhash))
 117 | +        self.log.debug('lastblockhash=%s' % (lastblockhash))

MarcoFalke commented at 7:58 PM on March 9, 2020:

nit: While changing this line, could also switch to ''.format(...)

jonatack commented at 8:09 PM on March 9, 2020:

agreed

MarcoFalke approved
MarcoFalke commented at 7:58 PM on March 9, 2020: member

ACK
test: add logging to wallet_listsinceblock.py d484279a46
jonatack force-pushed on Mar 9, 2020
MarcoFalke merged this on Mar 9, 2020
MarcoFalke closed this on Mar 9, 2020
jonatack deleted the branch on Mar 9, 2020
MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
deadalnix referenced this in commit 80303366ad on Jan 6, 2021
bitcoin locked this on Feb 15, 2022

Contributors

jonatack

MarcoFalke

Linked (view graph)

#17535 test: add block height test to listsinceblock.py