test: Disable mockforward scheduler unit test for now #18211

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2002-testSchedulerWorkaround changing 1 files +2 −0

MarcoFalke commented at 8:29 PM on February 25, 2020: member

This should be a workaround to fix #18174 in the short run and buy us more time to investigate the issue while ci runs are green again :pray:
MarcoFalke renamed this:
~~test: Work around scheduler_tests intermittent failures (take 2)~~
[WIP] test: Work around scheduler_tests intermittent failures (take 2)
on Feb 25, 2020
fanquake added the label Tests on Feb 25, 2020
DrahtBot commented at 10:22 PM on February 25, 2020: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.

fanquake commented at 11:02 PM on February 25, 2020: member

This is still failing on the Win64 and Linux x86_64 (no wallet) jobs:

test/scheduler_tests.cpp(157): Entering test case "mockforward"
test/scheduler_tests.cpp(187): error: in "scheduler_tests/mockforward": check num_tasks == 1ul has failed [3 != 1]
test/scheduler_tests.cpp(190): error: in "scheduler_tests/mockforward": check counter == 2 has failed [0 != 2]
test/scheduler_tests.cpp(196): error: in "scheduler_tests/mockforward": check delta > 2*60 && delta < 3*60 has failed
test/scheduler_tests.cpp(157): Leaving test case "mockforward"; testing time: 7640us

DrahtBot cross-referenced this on Feb 26, 2020 from issue util: Replace boost sleep with std sleep by MarcoFalke
MarcoFalke force-pushed on Feb 26, 2020
MarcoFalke renamed this:
~~[WIP] test: Work around scheduler_tests intermittent failures (take 2)~~
test: Work around scheduler_tests intermittent failures (take 2)
on Feb 26, 2020
MarcoFalke renamed this:
~~test: Work around scheduler_tests intermittent failures (take 2)~~
test: Work around scheduler_tests intermittent failures
on Feb 26, 2020
MarcoFalke force-pushed on Feb 26, 2020
MarcoFalke force-pushed on Feb 26, 2020
MarcoFalke force-pushed on Feb 26, 2020
MarcoFalke force-pushed on Feb 26, 2020

in src/util/time.cpp:20 in 3164f16788 outdated

  12 | @@ -13,8 +13,12 @@
  13 |  #include <boost/date_time/posix_time/posix_time.hpp>
  14 |  #include <boost/thread.hpp>
  15 |  #include <ctime>
  16 | +#include <thread>
  17 | +
  18 |  #include <tinyformat.h>
  19 |  
  20 | +void SleepFor(const std::chrono::microseconds& n) { std::this_thread::sleep_for(n); }

laanwj commented at 4:34 PM on February 26, 2020:

It looks like this newly added function is not used in this PR.

MarcoFalke force-pushed on Feb 26, 2020
MarcoFalke renamed this:
~~test: Work around scheduler_tests intermittent failures~~
[WIP] test: Work around scheduler_tests intermittent failures
on Feb 26, 2020
MarcoFalke force-pushed on Feb 26, 2020
test: Disable mockforward scheduler unit test for now fab2527515
MarcoFalke force-pushed on Feb 26, 2020
MarcoFalke renamed this:
~~[WIP] test: Work around scheduler_tests intermittent failures~~
test: Disable mockforward scheduler unit test for now
on Feb 26, 2020
laanwj commented at 6:11 PM on February 26, 2020: member

ACK fab2527515e8db944ae044bea8580e2cd9414bcd
fanquake approved
fanquake commented at 1:41 AM on February 27, 2020: member

ACK fab2527515e8db944ae044bea8580e2cd9414bcd - be good to get Travis back.
fanquake merged this on Feb 27, 2020
fanquake closed this on Feb 27, 2020
MarcoFalke deleted the branch on Feb 27, 2020
jonasschnelli commented at 9:37 AM on February 27, 2020: contributor

Looks like this merge has fixed the constant fails on https://bitcoinbuilds.org
sidhujag referenced this in commit d2de31888b on Feb 27, 2020
amitiuttarwar cross-referenced this on Feb 28, 2020 from issue scheduler test causing pthread_cond_timedwait: Invalid argument error by amitiuttarwar
MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
sidhujag referenced this in commit 5e1f190a26 on Nov 10, 2020
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#18174 WIP test: make mockscheduler test more reliable #18227 scheduler test causing pthread_cond_timedwait: Invalid argument error

test: Disable mockforward scheduler unit test for now #18211

Conflicts