Add a submodule check to CI #18019

issue laanwj opened this issue on January 29, 2020
  1. laanwj commented at 1:12 PM on January 29, 2020: member

    Add a check to the CI that checks whether the repository has any git submodules (either directly or of subtrees) and rejects it if so.

    In #17398 I accidentally almost added three submodules because they are part of the crc32c third-party repository, which was subtree'd there. This was only avoided because the gitian build failed.

    We do not make use of submodules so there doesn't need to be any exception.

    Useful skills:

    • Shell scripting

    Want to work on this issue?

    The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

    You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. laanwj added the label Tests on Jan 29, 2020
  3. laanwj added the label good first issue on Jan 29, 2020
  4. MarcoFalke commented at 1:36 PM on January 29, 2020: member

    This should be added to ./test/lint, right? Edit: I guess, inlining it somewhere in ./ci/test/ also works.

  5. chamajcpradel commented at 12:00 AM on February 1, 2020: none

    Sirs. I would like this request. Is there a bounty given for this request?

  6. fanquake commented at 12:01 AM on February 1, 2020: member

    Is there a bounty given for this request?

    No.

  7. emilengler cross-referenced this on Feb 2, 2020 from issue ci: Check for submodules by emilengler
  8. emilengler commented at 9:29 PM on February 2, 2020: contributor

    I implemented this in #18056

  9. Annasadra commented at 2:28 PM on February 8, 2020: none

    I would like this request too.

  10. laanwj referenced this in commit a2a77ba34f on Mar 5, 2020
  11. sidhujag referenced this in commit b7d0632c2c on Mar 5, 2020
  12. fanquake commented at 9:07 AM on March 9, 2020: member

    Done in #18056.

  13. fanquake closed this on Mar 9, 2020

  14. sidhujag referenced this in commit 71ebace671 on Nov 10, 2020
  15. PastaPastaPasta referenced this in commit 7425f34f93 on Jun 27, 2021
  16. PastaPastaPasta referenced this in commit 17b813e69b on Jun 28, 2021
  17. PastaPastaPasta referenced this in commit db46b1ed11 on Jun 29, 2021
  18. PastaPastaPasta referenced this in commit aec19f7bfe on Jul 1, 2021
  19. PastaPastaPasta referenced this in commit 55e6997970 on Jul 1, 2021
  20. PastaPastaPasta referenced this in commit 0e16d43494 on Jul 14, 2021
  21. PastaPastaPasta referenced this in commit a426a8b2e6 on Jul 14, 2021
  22. bitcoin locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC