Gitian-built unit tests fail on windows #18015

1. 
   MarcoFalke commented at 8:05 PM on January 28, 2020: member

   Current master:

   test_bitcoin.exe
   
   Running 389 test cases...
   
   test/script_p2sh_tests.cpp(200): error: in "script_p2sh_tests/set": txTo[1].IsStandard
   
   test/script_p2sh_tests.cpp(200): error: in "script_p2sh_tests/set": txTo[2].IsStandard
   
   test/script_p2sh_tests.cpp(200): error: in "script_p2sh_tests/set": txTo[3].IsStandard
   

   https://github.com/bitcoin/bitcoin/blame/master/src/test/script_p2sh_tests.cpp#L200

2. MarcoFalke added the label Bug on Jan 28, 2020
3. 
   MarcoFalke commented at 12:32 AM on January 29, 2020: member

   7dbc33f61 passes

4. MarcoFalke added the label Windows on Jan 29, 2020
5. MarcoFalke added this to the milestone 0.20.0 on Jan 29, 2020
6. 
   fanquake commented at 2:40 AM on January 29, 2020: member

   Confirmed it happens using a test_bitcoin cross-compiled in WSL. I only see the failure if all test cases are run, not if I use .\test_bitcoin.exe --run_test=script_p2sh_tests.

   The failure doesn't happen when you compile and test with MSVC.

7. 
   fanquake commented at 5:09 AM on January 29, 2020: member

   I've found the issue. Will open a PR to fix shortly.

8. fanquake cross-referenced this on Jan 29, 2020 from issue tests: reset fIsBareMultisigStd after bare-multisig tests by fanquake
9. MarcoFalke closed this on Jan 30, 2020

   ---

10. bitcoin locked this on Feb 15, 2022
11. PastaPastaPasta referenced this in commit f7dbd8c62e on Jan 24, 2023

Contributors

MarcoFalkefanquake

Milestone
0.20.0