build: don't embed a build-id when building libdmg-hfsplus #18004

1. 
   fanquake commented at 5:55 AM on January 26, 2020: member

   There was a reproducibility issue (IRC logs) with the osx 0.19.1rc1 gitian builds. The build-id embedded into the dmg tool was mismatching. It's possible that differing versions of binutils/ld were the cause.

   While it was resolved after rebuilding the base gitian image, whether an upstream package issue or fluke, we can remove the possibility of it happening in future by just not embedding a build-id into the dmg tool at all. Can close if it's not deemed worth it.

   You can test this change using the following:

   # build libdmg
   make native_libdmg-hfsplus_built -C depends/ HOST=x86_64-apple-darwin16 -j6 V=1
   
   # master
   readelf --string-dump .note.gnu.build-id /bitcoin/depends/work/build/x86_64-apple-darwin16/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-3830944ef98/build/dmg/dmg 
   
   String dump of section '.note.gnu.build-id':
     [     c]  GNU
     [    11]  CjRa?]?^V8?v?;%n??
   
   # this pr
   readelf --string-dump  .note.gnu.build-id /bitcoin/depends/work/build/x86_64-apple-darwin16/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-a72f53ab110/build/dmg/dmg 
   readelf: Warning: Section '.note.gnu.build-id' was not dumped because it does not exist!
   

2. fanquake added the label Build system on Jan 26, 2020
3. fanquake added the label Needs gitian build on Jan 26, 2020
4. fanquake requested review from laanwj on Jan 26, 2020
5. 
   practicalswift commented at 8:33 AM on January 26, 2020: contributor

   Concept ACK: reproducibility is good

6. DrahtBot removed the label Needs gitian build on Jan 27, 2020
7. 
   laanwj commented at 1:12 PM on February 5, 2020: member

   ACK 2b990a10eaa461c8f60123ee1c682be77c24f68b

   What I don't really understand yet is why this affected the build of one binary (a tool for MacOS DMG generation) but not the -linux build. But this can't hurt determinism, at least.

8. 
   laanwj commented at 1:15 PM on February 5, 2020: member

   BTW: it might be possible to provide -DCMAKE_C_FLAGS="-Wl,--build-id=none" on the cmake command line, passing it in directly, avoiding the need for a patch.

9. build: don't embed a build-id when building libdmg-hfsplus cb9e88e73a
10. fanquake force-pushed on Feb 6, 2020
11. 
    fanquake commented at 4:08 AM on February 6, 2020: member

    BTW: it might be possible to provide -DCMAKE_C_FLAGS="-Wl,--build-id=none"

    Sure, lets just do that rather than maintaining a patch. Updated.

12. laanwj added the label Needs backport (0.19) on Feb 10, 2020
13. 
    laanwj commented at 1:07 PM on February 10, 2020: member

    re-code-ACK going to test this in gitian locally cb9e88e73a042ff4e1c83289a6f8fa1db03fb093

14. 
    laanwj commented at 2:08 PM on February 10, 2020: member

    tested ACK cb9e88e73a042ff4e1c83289a6f8fa1db03fb093

    checked bitcoin-0.19.99-osx-unsigned.tar.gz:

    $ readelf --string-dump .note.gnu.build-id  dmg
    readelf: Warning: Section '.note.gnu.build-id' was not dumped because it does not exist!
    

    however, the same archive also contains genisoimage which still contains the section

    $ readelf --string-dump .note.gnu.build-id  genisoimage
    
    String dump of section '.note.gnu.build-id':
      [     c]  GNU
      [    13]  sm^^X
    

    is this a problem ?

15. bitcoin deleted a comment on Feb 10, 2020
16. 
    fanquake commented at 8:19 AM on February 11, 2020: member

    is this a problem ?

    I'd be happy to leave that as is for now, given we haven't seen any issues with it.

17. fanquake referenced this in commit 73a396e028 on Feb 12, 2020
18. fanquake merged this on Feb 12, 2020
19. fanquake closed this on Feb 12, 2020

    ---

20. fanquake deleted the branch on Feb 12, 2020
21. fanquake referenced this in commit 1964561a3a on Feb 28, 2020
22. fanquake cross-referenced this on Feb 28, 2020 from issue [0.19] Further 0.19 backports by fanquake
23. 
    fanquake commented at 4:15 AM on February 28, 2020: member

    Being backported in 18218.

24. fanquake removed the label Needs backport (0.19) on Feb 28, 2020
25. MarcoFalke referenced this in commit 05f5dd96c7 on Mar 4, 2020
26. MarkLTZ referenced this in commit ece88bae51 on Mar 13, 2020
27. deadalnix referenced this in commit b83925969d on Apr 3, 2020
28. MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
29. ftrader referenced this in commit a26e46bb6b on Aug 17, 2020
30. kwvg referenced this in commit 50c8348eaf on Nov 1, 2021
31. kwvg cross-referenced this on Nov 1, 2021 from issue merge bitcoin#16566...#18004 (auxillary backports: part 3) by kwvg
32. kwvg referenced this in commit 1e85e888b3 on Nov 1, 2021
33. kwvg referenced this in commit a2c9d90df2 on Nov 1, 2021
34. kwvg referenced this in commit be8550b50d on Nov 1, 2021
35. kwvg referenced this in commit d863696814 on Nov 1, 2021
36. UdjinM6 referenced this in commit c679fd9ab6 on Nov 2, 2021
37. pravblockc referenced this in commit 79f3e60506 on Nov 18, 2021
38. barton2526 cross-referenced this on Nov 22, 2021 from issue depends: Port libdmg-hfsplus changes from upstream by barton2526
39. bitcoin locked this on Feb 15, 2022

Contributors

fanquakepracticalswiftlaanwj

Review Requested
laanwj