test: check specific reject reasons in feature_csv_activation.py #17959

1. 
   theStack commented at 8:28 PM on January 18, 2020: contributor

   This is kind of a prequel to #17921: increases the general quality of the functional test feature_csv_activation.py by checking for the specific reject reasons whenever the sending of a block fails. To get the reason, we have to limit the script threads to 1 via the parameter -par=1, like it is also done in feature_cltv.py: https://github.com/bitcoin/bitcoin/blob/a654626f076a72416a3d354218d7107571d6caaf/test/functional/feature_cltv.py#L57-L61

   The commit also fixes a bug that was uncovered with this checks: for the BIP112 version 1 tx tests, txs from bip112txs_vary_OP_CSV_v1 have been add twice to the list failed_txs: https://github.com/bitcoin/bitcoin/blob/a654626f076a72416a3d354218d7107571d6caaf/test/functional/feature_csv_activation.py#L396-L397

   leading also to a block rejection as expected but for the wrong reason. It seems one of those two tx lists was meant to be bip112txs_vary_OP_CSV_v1 (without the _9) and it was a typo.

2. fanquake added the label Tests on Jan 18, 2020
3. 
   DrahtBot commented at 9:32 PM on January 18, 2020: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17921 (test: test OP_CSV empty stack fail in feature_csv_activation.py by theStack)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. theStack requested review from MarcoFalke on Jan 26, 2020
5. DrahtBot cross-referenced this on Feb 11, 2020 from issue test: test OP_CSV empty stack fail in feature_csv_activation.py by theStack
6. DrahtBot cross-referenced this on Feb 25, 2020 from issue test: Reduce unneeded whitelist permissions in tests by MarcoFalke
7. DrahtBot added the label Needs rebase on Feb 28, 2020
8. theStack force-pushed on Feb 28, 2020
9. 
   theStack commented at 8:01 AM on February 28, 2020: contributor

   Rebased.

10. fanquake removed the label Needs rebase on Feb 28, 2020
11. DrahtBot added the label Needs rebase on Feb 28, 2020
12. test: check specific reject reasons in feature_csv_activation.py

    this also fixes a bug that was uncovered with this checks:
    for the BIP112 version 1 tx tests, certain txs (bip112txs_vary_OP_CSV_v1) have
    been sent twice due to a typo, leading also to a failure as expected but for the
    wrong reason

    54be4e71d8
13. theStack force-pushed on Feb 28, 2020
14. 
    theStack commented at 7:49 PM on February 28, 2020: contributor

    Rebased again, since #17921 was merged :tada:

15. 
    MarcoFalke commented at 8:02 PM on February 28, 2020: member

    ACK 54be4e71d898de8f14e3269550d56097c023d1cc 📶

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA512
    
    ACK 54be4e71d898de8f14e3269550d56097c023d1cc 📶
    -----BEGIN PGP SIGNATURE-----
    
    iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    pUgJSwv9Eb9LTfTJ1Mvf5eIfjjUZKHlH8UekXS28tnUz95dcDNh2wkGr+Ntz06aB
    92A9vw7TLTwMykGLv6LJSDs7J/u1vp0uFmRPFdMSkbetgWVcLJQPIUKnsFYCauYF
    79MLxzntpnAEYW3jgIdPjnVxevJrwYUIYmwUMqaz+pkLcyVRURW8h9XnkiTI9a2f
    BU1vL5f6yfvv2XDLY5x3hiQcYP87RWW31bo+uPgWJMskBtXFoWM57UqMi2fawjAT
    iUxmenLBMCxypBcbv79jxj20BWvPxXfIzuOrHb0wZ8M5U3Tftong3ABZzwYlN6mZ
    YWOE7hczOyj0SthvUknwhUPyOq3AF803Nfuy9Nf9/axN4KsnbBChW1yhD3x+ARX9
    lJ7kvsuIcLWzWuwqEJMISsLD8LLygmWkBygEArp5sMywn3HjBG0ksKRrb4t68KqR
    H/0YaquKut4cP0RBz6mu/plX1Vxx5M/pAmXgVzx8Zj4v2o1nZqnS9Jdw1nPh1ihq
    gPExwUS5
    =3kpb
    -----END PGP SIGNATURE-----
    

    Timestamp of file with hash 4429e65ebc2aae20c0c04c8782b5ff09741bc040d5d109d24151d4cb4b2cfddd -

    </details>

16. DrahtBot removed the label Needs rebase on Feb 28, 2020
17. MarcoFalke merged this on Feb 28, 2020
18. MarcoFalke closed this on Feb 28, 2020

    ---

19. MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
20. theStack deleted the branch on Dec 1, 2020
21. bitcoin locked this on Feb 15, 2022

Contributors

theStackDrahtBotMarcoFalke

Review Requested
MarcoFalke