[0.18] scripts: fix check-symbols & check-security argument passing #17881

pull fanquake wants to merge 1 commits into bitcoin:0.18 from fanquake:018_backport_17857 changing 1 files +2 −2
  1. fanquake commented at 7:58 AM on January 6, 2020: member

    Backport of #17857.

    The first argument in bin_PROGRAMS (bitcoind) was being silently dropped and never passed into the check-security.py or check-symbols.py scripts.

    This has been the case since the scripts were added to the makefile in https://github.com/bitcoin/bitcoin/commit/f3d3eaf78eb51238d799d8f20a585550d1567719.

    Example of the behavior:

    # touch a, touch b, touch c
    # python3 args.py < a b c
    
    import sys
    if __name__ == '__main__':
        print(sys.argv)
        # ['args.py', 'b', 'c']
    
        # if you add some lines to "a",
        # you'll see them here..
        for line in sys.stdin:
            print(line)
    

    Github-Pull: #17857 Rebased-From: 71af793512100ee7d508c3fb815af47925fe80ba

  2. scripts: fix check-symbols & check-security argument passing
    The first argument in bin_PROGRAMS (bitcoind) was being silently
    dropped and never passed into the check-security.py or check-symbols.py scripts.
    
    This has been the case since the scripts were added to the makefile in
    https://github.com/bitcoin/bitcoin/commit/f3d3eaf78eb51238d799d8f20a585550d1567719.
    
    Example of the behavior:
    
    ```python
    # touch a, touch b, touch c
    # python3 args.py < a b c
    
    import sys
    if __name__ == '__main__':
        print(sys.argv)
        # ['args.py', 'b', 'c']
    
        # if you add some lines to "a",
        # you'll see them here..
        for line in sys.stdin:
            print(line)
    ```
    
    Github-Pull: #17857
    Rebased-From: 71af793512100ee7d508c3fb815af47925fe80ba
    9a0ebb7f02
  3. fanquake added the label Backport on Jan 6, 2020
  4. fanquake added this to the milestone 0.18.2 on Jan 6, 2020
  5. fanquake cross-referenced this on Jan 6, 2020 from issue scripts: fix symbol-check & security-check argument passing by fanquake
  6. fanquake requested review from laanwj on Jan 10, 2020
  7. fanquake referenced this in commit a05d14d4a0 on Jan 12, 2020
  8. fanquake merged this on Jan 12, 2020
  9. fanquake closed this on Jan 12, 2020

  10. fanquake deleted the branch on Jan 12, 2020
  11. bitcoin locked this on Feb 15, 2022
Contributors


laanwj

Labels

Milestone
0.18.2


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC