build, qt: Possible unset bitcoin_cv_qt58 variable #17821

issue hebasto opened this issue on December 28, 2019

hebasto commented at 9:38 PM on December 28, 2019: member

The bitcoin_cv_qt58 variable is used in _BITCOIN_QT_FIND_LIBS_WITHOUT_PKGCONFIG and _BITCOIN_QT_FIND_STATIC_PLUGINS macros.

But it is set by _BITCOIN_QT_CHECK_QT58 macro only if else branch is executed: https://github.com/bitcoin/bitcoin/blob/b931f61b9ab098ea4ea8fbe4cbf0b03c566c3f63/build-aux/m4/bitcoin_qt.m4#L96-L100
hebasto added the label Bug on Dec 28, 2019
fanquake added the label Build system on Dec 28, 2019
fanquake commented at 10:27 PM on February 4, 2020: member

I think a PR with a fix/for discussion would be a better approach than having an issue open for this. Going to close for now.
fanquake closed this on Feb 4, 2020
hebasto cross-referenced this on Mar 24, 2020 from issue build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts including Windows by hebasto
bitcoin locked this on Feb 15, 2022

Contributors

Labels