sendmany/bumpfee: Avoid address reuse and partial spends as per walle… #17712

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:avoid_reuse_sm_bf changing 1 files +11 −0

instagibbs commented at 5:12 PM on December 10, 2019: member

…t flags

partiall resolves #17706
sendmany/bumpfee: Avoid address reuse and partial spends as per wallet flags 7fbd239320
fanquake added the label Wallet on Dec 10, 2019
fanquake added the label RPC/REST/ZMQ on Dec 10, 2019
promag commented at 2:38 PM on December 12, 2019: member

Concept ACK. With this change there's 3 times the same code, maybe too soon to factor out to some function.
instagibbs commented at 2:41 PM on December 12, 2019: member

@promag we could make CoinControl take a wallet param, and initialize it as per wallet defaults(or something like this)
promag commented at 3:18 PM on December 12, 2019: member

Or some setter like CCoinControl::SetAvoidAddressReuse(bool) that would update m_avoid_partial_spends too.
instagibbs cross-referenced this on Dec 12, 2019 from issue `avoid_reuse` support for non-`sendtoaddress` calls by instagibbs
instagibbs commented at 8:28 PM on December 12, 2019: member

turns out it's already handled in coin selection directly, closing.
instagibbs closed this on Dec 12, 2019
bitcoin locked this on Dec 16, 2021

Contributors

Labels