ui: disable 3rd-party tx-urls when wallet disabled #17694

pull brakmic wants to merge 1 commits into bitcoin:master from brakmic:options-display-dialog changing 1 files +3 −1

brakmic commented at 6:17 PM on December 7, 2019: contributor

This PR closes #17683 by removing 3rd-party Url-Label and -TextBox from Display Options in wallet-disabled mode.
fanquake added the label GUI on Dec 7, 2019
jonasschnelli commented at 5:58 AM on December 9, 2019: contributor

Yes. Probably a good idea. It can always come back in node mode in case someone once adds an option to inspect the mempool or blocks, etc.

Concept ACK
promag commented at 8:43 AM on December 9, 2019: member

Could also disable with -disablewallet?
brakmic commented at 9:02 AM on December 9, 2019: contributor

Could also disable with -disablewallet?

Many thanks for the hint. It now also disables the textbox when -disablewallet.
ui: disable 3rd-party tx-urls when wallet disabled 48a5c92f9e
in src/qt/optionsdialog.cpp:113 in b77d9da410 outdated
```
 109 | @@ -108,7 +110,12 @@ OptionsDialog::OptionsDialog(QWidget *parent, bool enableWallet) :
 110 |              ui->lang->addItem(locale.nativeLanguageName() + QString(" (") + langStr + QString(")"), QVariant(langStr));
 111 |          }
 112 |      }
 113 | +#ifdef ENABLE_WALLET
```
laanwj commented at 9:47 AM on December 9, 2019:

Is this change even necessary? I think the above (!enableWallet) change covers all cases where there's no wallet? if so, it's good to avoid introducing conditional compilation if possible.

brakmic commented at 9:59 AM on December 9, 2019:

I have tested it and yes, it doesn't need this #ifdef. Many thanks!
laanwj commented at 10:01 AM on December 9, 2019: member

Code review ACK 48a5c92f9ef6634375a3f52812cf3d511c37699d
fanquake approved
fanquake commented at 2:53 PM on December 9, 2019: member

ACK 48a5c92f9ef6634375a3f52812cf3d511c37699d - tested with and without wallet (compiled out and -disablewallet).
fanquake referenced this in commit 05c23488c2 on Dec 9, 2019
fanquake merged this on Dec 9, 2019
fanquake closed this on Dec 9, 2019
MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
deadalnix referenced this in commit 542557427b on Nov 7, 2020
bitcoin locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17683 Don't display "Third party transaction URLs" setting when built with no wallet