Unbreak build with Boost 1.72.0 #17654

1. 
   jbeich commented at 8:01 PM on December 2, 2019: contributor

   Regressed by https://github.com/boostorg/filesystem/commit/9a14c37d6f95. See error log. https://github.com/bitcoin/bitcoin/blob/35eda631ed3bd23d4a41761a85a96f925d4a6337/src/fs.h#L14

2. fanquake added the label Wallet on Dec 2, 2019
3. 
   laanwj commented at 3:19 PM on December 3, 2019: member

   ACK 90916ddf17dc39699b38ebd89e2d049b279daa08

4. 
   laanwj commented at 3:33 PM on December 3, 2019: member

   Note that boost 1.72 is not released yet: the site shows it in progress https://www.boost.org/users/history/in_progress.html

   Can we be sure this doesn't get corrected before the release? Might make sense to wait for that.

5. MarcoFalke added the label Waiting for author on Dec 5, 2019
6. 
   jbeich commented at 6:21 PM on December 11, 2019: contributor

   Boost 1.72 is released and landed in FreeBSD Ports. The fix here is still required.

7. 
   MarcoFalke commented at 6:27 PM on December 11, 2019: member

   We should probably just remove BOOST_FILESYSTEM_NO_DEPRECATED again. The minimum version of boost is not going to be bumped ever again, because we will be removing boost before that happens. And until that happens, we actually want to use the deprecated features.

8. wallet: unbreak with boost 1.72

   wallet/walletutil.cpp:77:23: error: no member named 'level' in 'boost::filesystem::recursive_directory_iterator'
           } else if (it.level() == 0 && it->symlink_status().type() == fs::regular_file && IsBerkeleyBtree(it...
                      ~~ ^

   a64e97dd47
9. 
   jbeich commented at 6:58 PM on December 11, 2019: contributor

   remove BOOST_FILESYSTEM_NO_DEPRECATED

   Works for me.

10. MarcoFalke removed the label Waiting for author on Dec 11, 2019
11. 
    MarcoFalke commented at 7:35 PM on December 11, 2019: member

    ACK a64e97dd476bda7c7981979d045b0d06d6f7ce47

12. MarcoFalke added this to the milestone 0.19.1 on Dec 11, 2019
13. MarcoFalke added the label Needs backport (0.19) on Dec 11, 2019
14. fanquake removed the label Wallet on Dec 11, 2019
15. fanquake added the label Utils/log/libs on Dec 11, 2019
16. laanwj referenced this in commit ddecb671f0 on Dec 13, 2019
17. laanwj merged this on Dec 13, 2019
18. laanwj closed this on Dec 13, 2019

    ---

19. sidhujag referenced this in commit 93e31c290f on Dec 13, 2019
20. scpeters cross-referenced this on Dec 27, 2019 from issue boost 1.72.0 by fxcoudert
21. fanquake cross-referenced this on Jan 3, 2020 from issue bitcoind fails to compile with boost 1.72.0 by meeDamian
22. fanquake referenced this in commit b9f1bc0fc1 on Jan 3, 2020
23. fanquake cross-referenced this on Jan 3, 2020 from issue [0.19] Backports by fanquake
24. fanquake cross-referenced this on Jan 3, 2020 from issue Update .level() to .depth() by lord-cow
25. luke-jr referenced this in commit 2d0e76e8ff on Jan 5, 2020
26. fanquake removed the label Needs backport (0.19) on Jan 5, 2020
27. 
    fanquake commented at 11:59 PM on January 5, 2020: member

    Being backported in 17858.

28. laanwj referenced this in commit bb123c6527 on Jan 8, 2020
29. fanquake cross-referenced this on Jan 15, 2020 from issue replace deprecated method of recursive_directory_iterator with the st… by btc-coder
30. bektar cross-referenced this on Jan 21, 2020 from issue Build fails on FreeBSD 12.1 by bektar
31. fanquake cross-referenced this on Feb 1, 2020 from issue wallet: replace boost deprecated method call by jakubtrnka
32. MarkLTZ referenced this in commit 2e6abb1507 on Mar 13, 2020
33. MarkLTZ referenced this in commit ece88bae51 on Mar 13, 2020
34. MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
35. jasonbcox referenced this in commit e5825c36d5 on Sep 4, 2020
36. sidhujag referenced this in commit d7cc210ce6 on Nov 10, 2020
37. PastaPastaPasta referenced this in commit bad62728f8 on Jun 27, 2021
38. PastaPastaPasta referenced this in commit d5d78953ab on Jun 28, 2021
39. PastaPastaPasta referenced this in commit 89e7c8d6c7 on Jun 29, 2021
40. PastaPastaPasta referenced this in commit 83df970027 on Jul 1, 2021
41. PastaPastaPasta referenced this in commit 5ebd2b8387 on Jul 1, 2021
42. barton2526 referenced this in commit d1536d85a4 on Jul 12, 2021
43. barton2526 cross-referenced this on Jul 12, 2021 from issue trivial: Unbreak build with Boost 1.72.0 by barton2526
44. barton2526 referenced this in commit 326d33bea6 on Jul 13, 2021
45. PastaPastaPasta referenced this in commit c572291a16 on Jul 14, 2021
46. PastaPastaPasta referenced this in commit be83887f12 on Jul 14, 2021
47. PastaPastaPasta referenced this in commit fc6f390b5f on Jul 15, 2021
48. str4d cross-referenced this on Dec 6, 2021 from issue Backport changes to `src/fs.{cpp,h}` by str4d
49. Munkybooty referenced this in commit 861ef02929 on Dec 9, 2021
50. Munkybooty referenced this in commit fc6f77f098 on Dec 9, 2021
51. Munkybooty referenced this in commit e32f0d5d86 on Dec 9, 2021
52. Munkybooty referenced this in commit 16f7583e71 on Dec 23, 2021
53. bitcoin locked this on Feb 15, 2022

Contributors

jbeichlaanwjMarcoFalkefanquake

Milestone
0.19.1