Align assignment operator vertically #17630

pull wooseopkim wants to merge 1 commits into bitcoin:master from wooseopkim:patch-1 changing 1 files +1 −1
  1. wooseopkim commented at 1:40 AM on November 29, 2019: none

    Since the one for line 131 is not aligned to others.

  2. Align assignment operator vertically 8823ff130d
  3. fanquake closed this on Nov 29, 2019

  4. amitiuttarwar commented at 6:10 PM on November 29, 2019: contributor

    hi @wooseopkim, thanks for your interest. since the main bottleneck in this project is review, we don't accept small fixes like this.

    you can read more about it here: contributing.md

    Trivial pull requests or pull requests that refactor the code with no clear benefits may be immediately closed by the maintainers to reduce unnecessary workload on reviewing.

    if you're looking for a good place to start, I recommend checking out the good first issue tag

  5. MarcoFalke commented at 6:59 PM on December 3, 2019: member

    Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:

    • Time spent on review
    • Accidental introduction of bugs
    • (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.

    For more information about refactoring changes and stylistic cleanup, see

    Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

    Let me know if you have any questions.

  6. wooseopkim deleted the branch on Dec 5, 2019
  7. bitcoin locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC