This adds and uses a new transaction type PureTransaction.
The underlying class has no transaction hash compiled in. So
it is safe to use (and faster) wherever it compiles.
The existing CMutableTransaction retains the behavior to calculate the tx hash on demand. Use of CMutableTransaction makes compile-time complexity analysis impossible.
The existing CTransaction retains the behavior to cache the hash on initialization.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
So I did some measurements: While this is a clear performance win, it seems the performance is dominated by shuffling the data around multiple times:
Before:
disk -> deserialize -> hash -> serialize -> hex string -> json
After:
disk -> deserialize -> ____ -> serialize -> hex string -> json
Hashing takes 10%-25% on intel CPUs. Didn't try arm.
master:
faaa142412:
Those new types are currently unused. The underlying class has no
transaction hash compiled in. So it is safe to use wherever it compiles.
The existing CMutableTransaction retains the behavior to calculate the
tx hash on demand. Use of CMutableTransaction makes compile-time
complexity analysis impossible.
The existing CTransaction retains the behavior to cache the hash on
initialization.
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.