wallet: Remove unused boost::this_thread::interruption_point #17405

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1911-walletNoBoost changing 1 files +5 −7
  1. MarcoFalke commented at 9:03 PM on November 7, 2019: member

    BerkeleyEnvironment::Open is only called from the main thread (init) or an http rpc thread, neither of which can be interrupted, so remove the useless interruption point.

    BerkeleyEnvironment{} is only used in tests, which run in a single process/thread, so remove the useless interruption point.

  2. wallet: Remove unused boost::this_thread::interruption_point fad1de66a2
  3. MarcoFalke added the label Refactoring on Nov 7, 2019
  4. MarcoFalke force-pushed on Nov 7, 2019
  5. MarcoFalke added the label Wallet on Nov 7, 2019
  6. laanwj commented at 11:49 PM on November 7, 2019: member

    Also, interruption points are supposed to be called in loops for long operations, not one at the beginning of constructors. This was very strange.

    ACK fad1de66a29bf6bd348a932150dad7d472feb3d0

  7. DrahtBot commented at 12:38 PM on November 8, 2019: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17410 (Rename db log category to walletdb (like coindb) by laanwj)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. fanquake approved
  9. fanquake commented at 1:54 PM on November 8, 2019: member

    ACK fad1de66a29bf6bd348a932150dad7d472feb3d0

  10. fanquake referenced this in commit 8021392b82 on Nov 8, 2019
  11. fanquake merged this on Nov 8, 2019
  12. fanquake closed this on Nov 8, 2019

  13. MarcoFalke deleted the branch on Nov 8, 2019
  14. sidhujag referenced this in commit 36a012eb22 on Nov 9, 2019
  15. MarkLTZ referenced this in commit b171112df1 on Nov 29, 2019
  16. MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
  17. MarcoFalke cross-referenced this on Jun 5, 2020 from issue Remove unused boost/thread by MarcoFalke
  18. jasonbcox referenced this in commit e51055fa30 on Oct 1, 2020
  19. sidhujag referenced this in commit 0f9fde4a51 on Nov 10, 2020
  20. UdjinM6 referenced this in commit 5c5f9b5fb6 on Jul 15, 2021
  21. UdjinM6 referenced this in commit 7de223cd2e on Jul 15, 2021
  22. UdjinM6 referenced this in commit 1722e83588 on Jul 15, 2021
  23. kwvg referenced this in commit f20f872592 on Jul 16, 2021
  24. UdjinM6 referenced this in commit 730a89f8ed on Jul 16, 2021
  25. Bushstar cross-referenced this on Sep 9, 2021 from issue Boost usage reduction by Bushstar
  26. Bushstar cross-referenced this on Sep 10, 2021 from issue C++17 and reduce Boost usage by Bushstar
  27. str4d cross-referenced this on Dec 6, 2021 from issue Backport upstream PRs that remove Boost usage by str4d
  28. bitcoin locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC