MarcoFalke
commented at 9:03 PM on November 7, 2019:
member
BerkeleyEnvironment::Open is only called from the main thread (init) or an http rpc thread, neither of which can be interrupted, so remove the useless interruption point.
BerkeleyEnvironment{} is only used in tests, which run in a single process/thread, so remove the useless interruption point.
MarcoFalke added the label Refactoring on Nov 7, 2019
MarcoFalke force-pushed on Nov 7, 2019
MarcoFalke added the label Wallet on Nov 7, 2019
laanwj
commented at 11:49 PM on November 7, 2019:
member
Also, interruption points are supposed to be called in loops for long operations, not one at the beginning of constructors. This was very strange.
ACKfad1de66a29bf6bd348a932150dad7d472feb3d0
DrahtBot
commented at 12:38 PM on November 8, 2019:
contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
#17410 (Rename db log category to walletdb (like coindb) by laanwj)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake approved
fanquake
commented at 1:54 PM on November 8, 2019:
member
ACKfad1de66a29bf6bd348a932150dad7d472feb3d0
fanquake referenced this in commit 8021392b82 on Nov 8, 2019
fanquake merged this on Nov 8, 2019
fanquake closed this on Nov 8, 2019
MarcoFalke deleted the branch on Nov 8, 2019
sidhujag referenced this in commit 36a012eb22 on Nov 9, 2019
MarkLTZ referenced this in commit b171112df1 on Nov 29, 2019
MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC