Remove redundant class file include from test_bitcoin msvc project #17404

pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:msvc_test changing 1 files +3 −5
  1. sipsorcery commented at 7:50 PM on November 7, 2019: member

    #17364 & #17384 overlapped and both added the same line of ..\..\src\test\util\*.cpp to test_bitcoin.vcxproj. This didn't break the build but does result in duplicate symbol warnings. This PR cleans it up and removes the additional redundant line of ..\..\src\test\util\setup_common.cpp which will also be covered by the wildcard include.

  2. fanquake added the label Windows on Nov 7, 2019
  3. fanquake added the label Build system on Nov 7, 2019
  4. Remove redundant class file includes from test_bitcoin project. b80f7db832
  5. in build_msvc/test_bitcoin/test_bitcoin.vcxproj:15 in e6f7fa2da6 outdated 
      13 | @@ -14,10 +14,8 @@
  14 |      <ClCompile Include="..\..\src\test\gen\*_gen.cpp" />
  15 |      <ClCompile Include="..\..\src\wallet\test\*_tests.cpp" />
    MarcoFalke commented at 7:55 PM on November 7, 2019:

    Can this list be sorted? (e.g. the vim editor has a sort command)

    This makes it easier to spot duplicates

    sipsorcery commented at 8:04 PM on November 7, 2019:

    Sure, good idea. Done.

  6. sipsorcery force-pushed on Nov 7, 2019
  7. MarcoFalke commented at 8:11 PM on November 7, 2019: member

    ACK b80f7db832390a1b43829c1d5857f382c45b0df6 🔅

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK b80f7db832390a1b43829c1d5857f382c45b0df6 🔅
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgm4Qv+Jf4bz7I4WBxi/fyyAor/jkc2ujOySG3obfOP8w2yNQWsfkkKrKpu5H41
c/eNy3oxPBYYfRY2jq6Q0Si6QBppr9IxUrSW2pCgx0xhjzn/cppirOorWhnlars3
WrZCOnxrg4FuELocaLrz9G+XPq0kjNiy5F8nXWi6HY5hkoNReHzYfgiLkSga0CkY
Y1ILnoqbCQO6GxevHiokd8Lw71JWNnEICN77jHTk6kp+BtB0UjaezuXwAkbTNjga
1VcJH9nlNcEGQe+9uEcDMLuN4LiUcBwzcZpdJCgGFCJF/h+NNS1fy7h/Xi6JQGn9
sU2WNbN6UagmgrLYFZNHnJNyesFSIY4YxdzWQgREpSeI/erLtcmXFj+MWaXvjBvU
t2Dx5n7vHlxC+M5tiUaSNddRtIR7UlL11ZKDGYgRjXWjWK2/VXEORWpVeOYHyowY
M8ALQcxNaizbfOZB8nnBNS55XjkTXXDdFmF4GQL8OQZkbHd3LlKLCPlP3wLsj7+6
BCF1pgLg
=kJ1b
-----END PGP SIGNATURE-----

    Timestamp of file with hash 48b8ab124186c99b79562c95371bdbb65826b2a60e11e2577b028255d8d07fa4 -

    </details>

  8. fanquake approved
  9. fanquake commented at 8:42 PM on November 7, 2019: member

    ACK b80f7db832390a1b43829c1d5857f382c45b0df6 - tested a build on a Windows machine. No longer see the warnings shown below:

    windows_dups

  10. fanquake referenced this in commit 2fb6140d58 on Nov 7, 2019
  11. fanquake merged this on Nov 7, 2019
  12. fanquake closed this on Nov 7, 2019
  13. sipsorcery deleted the branch on Nov 7, 2019
  14. MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
  15. bitcoin locked this on Dec 16, 2021
Contributors
sipsorceryMarcoFalkefanquake
Labels
WindowsBuild system
Linked (view graph)
#17364 Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes#17384 test: Create new test library
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC