TestShell: Fix typos & implement cleanups #17378 pull jachiang wants to merge 4 commits into bitcoin:master from jachiang:2019-11-testshell-followup changing 2 files +6 −8 Conversation Commits4 Files2 Check jachiang commented at 1:06 PM on November 5, 2019: contributor This PR follows up on #17288 and fixes typos and implements code clean-ups suggested by reviewers of 19139ee. Typo in test_shell.py warning Typo in test-shell.md code block Simplified default setting of num_nodes in TestShell.setup() Enable initializer chaining: TestShell().setup() TestShell: Fix typo in TestShell warning printout d3ed06e2cd Doc: Remove backticks in test-shell.md code block 9c7806e4bf TestShell: Simplify default setting of num_nodes a8dea45524 TestShell: Return self from setup() This allows user to chain setup() to the initializer. test-shell.md code examples have been updated to reflect this. 2493770e36 fanquake added the label Tests on Nov 5, 2019 MarcoFalke commented at 1:26 PM on November 5, 2019: member ACK 2493770e365a7e30117dc1b8d228f9cbed97f7e1 instagibbs commented at 2:28 PM on November 5, 2019: member tACK https://github.com/bitcoin/bitcoin/pull/17378/commits/2493770e365a7e30117dc1b8d228f9cbed97f7e1 jachiang cross-referenced this on Nov 5, 2019 from issue Added TestShell class for interactive Python environments. by jachiang jnewbery commented at 4:58 PM on November 5, 2019: member utACK 2493770e365a7e30117dc1b8d228f9cbed97f7e1 Can probably squash into a single commit MarcoFalke referenced this in commit 54a337478d on Nov 5, 2019 MarcoFalke merged this on Nov 5, 2019 MarcoFalke closed this on Nov 5, 2019 MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ jasonbcox referenced this in commit 1926522d92 on Nov 3, 2020 jasonbcox referenced this in commit 2c67964341 on Nov 3, 2020 bitcoin locked this on Dec 16, 2021 ContributorsjachiangMarcoFalkeinstagibbsjnewbery LabelsTests Linked (view graph)#17288 Added TestShell class for interactive Python environments.
