code for blocksonly disagrees with documentation #17294

issue dooglus opened this issue on October 29, 2019

dooglus commented at 12:53 AM on October 29, 2019: contributor

The docs for blocksonly say that "Transactions from the wallet or RPC are not affected" but the code says:

if (gArgs.GetBoolArg("-blocksonly", DEFAULT_BLOCKSONLY) && gArgs.SoftSetBoolArg("-walletbroadcast", false)) {
    LogPrintf("%s: parameter interaction: -blocksonly=1 -> setting -walletbroadcast=0\n", __func__);
}

Here's the relevant documentation:

-blocksonly
   Whether to reject transactions from network peers. Transactions from the
   wallet or RPC are not affected. (default: 0)

-walletbroadcast
   Make the wallet broadcast transactions (default: 1)

Doesn't that imply that blocksonly does affect transactions from the wallet?

dooglus added the label Bug on Oct 29, 2019
MarcoFalke commented at 1:17 PM on October 29, 2019: member

Correct. The documentation should be updated.
MarcoFalke added the label Docs on Oct 29, 2019
MarcoFalke added the label good first issue on Oct 29, 2019
MarcoFalke commented at 1:18 PM on October 29, 2019: member

My bad in fa8ced32a60dea37ac169241cf9a1f708ef46c4b
birtony commented at 3:52 PM on October 29, 2019: none

Hey, I would be happy to work on this!
birtony cross-referenced this on Oct 29, 2019 from issue doc: Updated -blocksonly documentation by birtony
MarcoFalke cross-referenced this on Dec 4, 2019 from issue Balance is 0 after send transaction in testnet v0.19 and blocksonly flag enabled by webloft
MarcoFalke added the label Up for grabs on Dec 4, 2019
glowang commented at 11:46 PM on March 14, 2020: contributor

I will work on this!
glowang referenced this in commit aeec15f0f5 on Mar 20, 2020
glowang cross-referenced this on Mar 20, 2020 from issue doc: Update init and reduce-traffic docs for -blocksonly by glowang
fanquake removed the label Up for grabs on Mar 23, 2020
glowang referenced this in commit 1d503e7beb on Mar 25, 2020
glowang referenced this in commit 3019ba95a4 on Mar 25, 2020
glowang referenced this in commit be1b3b94cc on Mar 25, 2020
glowang referenced this in commit 9a7d39bd05 on Mar 25, 2020
glowang referenced this in commit 869327ca6e on Mar 26, 2020
glowang referenced this in commit 408585f8f1 on Mar 29, 2020
MarcoFalke closed this on Mar 29, 2020
bitcoin locked this on Feb 15, 2022
vijaydasmp referenced this in commit 744970234d on Mar 24, 2022
vijaydasmp referenced this in commit 6000028733 on Mar 27, 2022
vijaydasmp referenced this in commit 4f27607598 on Mar 28, 2022
vijaydasmp referenced this in commit e736406c6f on Mar 31, 2022
vijaydasmp referenced this in commit 53cc35017c on Mar 31, 2022
vijaydasmp referenced this in commit 42ddb4546d on Mar 31, 2022
vijaydasmp referenced this in commit 89c3e09c97 on Mar 31, 2022
vijaydasmp referenced this in commit c2269e1670 on Apr 1, 2022
vijaydasmp referenced this in commit 29c78e2f44 on Apr 2, 2022

Contributors

Labels

Bug Docs good first issue

Linked (view graph)

#17305 doc: Updated -blocksonly documentation #17662 Balance is 0 after send transaction in testnet v0.19 and blocksonly flag enabled #18391 doc: Update init and reduce-traffic docs for -blocksonly