util: Filter out macOS process serial number #17184

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:patch-1 changing 1 files +9 −0

hebasto commented at 6:13 AM on October 18, 2019: member

Fix #17179
util: Filter out macOS process serial number b5f0be3879
fanquake added the label macOS on Oct 18, 2019
fanquake added the label Utils/log/libs on Oct 18, 2019
hebasto commented at 6:49 AM on October 18, 2019: member

@fanquake Could "Needs gitian build" label be assigned to this PR?
jonasschnelli added the label Needs gitian build on Oct 18, 2019
jonasschnelli commented at 7:07 AM on October 18, 2019: contributor

Concept ACK. It fairly is a bit of a hack. Could we also add a link to the macOS documentation where this magical parameter is described?
promag commented at 7:08 AM on October 18, 2019: member

Concept ACK, code LGTM.
hebasto commented at 7:11 AM on October 18, 2019: member

Could we also add a link to the macOS documentation where this magical parameter is described?

All the links to the macOS docs I found are dead, unfortunately ((
hebasto cross-referenced this on Oct 18, 2019 from issue macos: shutdown on first run due to -psn_ parameter by fanquake
laanwj commented at 7:57 AM on October 18, 2019: member

ACK b5f0be38790ecc87a1e537edeca5923f608bc68c

I agree it's a hack, but it's also harmless, and apparently the same Qt used to do, when we still passed the command line arguments to it.
laanwj added the label Needs backport (0.19) on Oct 18, 2019
laanwj cross-referenced this on Oct 18, 2019 from issue Replace #16578 with a more specific solution by laanwj
fanquake commented at 12:00 PM on October 18, 2019: member
@jonasschnelli the Qt filtering was happening here.
```
#ifdef Q_OS_MAC
        } else if (strncmp(arg, "-psn_", 5) == 0) {
            // eat "-psn_xxxx" on Mac, which is passed when starting an app from Finder.
```
Documentation on the -psn_ params seems to be pretty light.
MarcoFalke commented at 12:23 PM on October 18, 2019: member

unsigned ACK b5f0be38790ecc87a1e537edeca5923f608bc68c
promag commented at 7:41 PM on October 18, 2019: member

ACK b5f0be38790ecc87a1e537edeca5923f608bc68c.
fanquake approved
fanquake commented at 9:38 PM on October 18, 2019: member

ACK b5f0be38790ecc87a1e537edeca5923f608bc68c - Tested that this fixes #17179.
fanquake referenced this in commit b6e34afe97 on Oct 18, 2019
fanquake merged this on Oct 18, 2019
fanquake closed this on Oct 18, 2019
fanquake removed the label Needs gitian build on Oct 18, 2019
hebasto deleted the branch on Oct 19, 2019
fanquake referenced this in commit 334e27ed5a on Oct 19, 2019
fanquake cross-referenced this on Oct 19, 2019 from issue [0.19.0] Backports by fanquake
fanquake removed the label Needs backport (0.19) on Oct 19, 2019
laanwj referenced this in commit 5b68d1654f on Oct 21, 2019
HashUnlimited referenced this in commit 27834d12df on Nov 17, 2019
fxtc referenced this in commit 1fab7e6f75 on Nov 25, 2019
fxtc referenced this in commit a057618ae5 on Nov 25, 2019
MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
kwvg referenced this in commit 98c8be113d on Jul 15, 2021
kwvg referenced this in commit acd9695474 on Jul 15, 2021
kwvg referenced this in commit c4d45d3312 on Jul 20, 2021
kwvg referenced this in commit 75f90b180c on Jul 20, 2021
kwvg referenced this in commit 2d80306d30 on Jul 20, 2021
kwvg referenced this in commit a5174e588c on Jul 20, 2021
kwvg referenced this in commit 1bf7338901 on Aug 1, 2021
Fabcien referenced this in commit cd1f3330b8 on Aug 24, 2021
kwvg referenced this in commit 0d3bcbf173 on Aug 24, 2021
kwvg referenced this in commit d04c32983f on Aug 24, 2021
kwvg referenced this in commit f550259e2c on Aug 25, 2021
kwvg referenced this in commit de52d0fb25 on Aug 26, 2021
kwvg referenced this in commit 413e5fcbc7 on Aug 26, 2021
kwvg referenced this in commit 4db69829d4 on Aug 27, 2021
kwvg referenced this in commit 80c9e9ab1f on Aug 30, 2021
kwvg referenced this in commit 9f1fd3f3fb on Aug 31, 2021
Munkybooty referenced this in commit 6ce7e306b1 on Dec 9, 2021
bitcoin locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17179 macos: shutdown on first run due to -psn_ parameter #17187 Replace #16578 with a more specific solution #17197 [0.19.0] Backports