gui: Hide or grey out used addresses #17174

issue MarcoFalke opened this issue on October 17, 2019
  1. MarcoFalke commented at 1:47 PM on October 17, 2019: member

    The gui keeps track of some addresses in the "receiving addresses" and "sending addresses" tabs. In light of address reuse and accidental double-payments, it could make sense to hide or dull out addresses which have been used. Maybe even show the txid.

  2. MarcoFalke added the label Feature on Oct 17, 2019
  3. MarcoFalke added the label Brainstorming on Oct 17, 2019
  4. MarcoFalke added the label GUI on Oct 17, 2019
  5. za-kk commented at 8:00 PM on October 17, 2019: contributor

    Agreed, willing to work on this if consensus thinks it would be a valuable change.

  6. MarcoFalke removed the label Brainstorming on Oct 17, 2019
  7. MarcoFalke commented at 8:19 PM on October 17, 2019: member

    The issue has three ":+1:", which means overall agreement, I guess

  8. za-kk commented at 8:22 PM on October 17, 2019: contributor

    Nice, will start working on this and open a PR once complete 👍

  9. promag commented at 12:03 PM on November 2, 2019: member

    Concept ACK. Do we already track used addresses in the wallet (beside keypool)? If not then I think we should start by doing it otherwise implementing this can hurt the GUI for big wallets. Or am I missing something?

  10. laanwj added the label Wallet on Nov 2, 2019
  11. za-kk commented at 12:36 PM on November 2, 2019: contributor

    We already track used addresses in the address book via the SetUsedDestinationState, however this is only when the wallet has the avoid_reuse flag set.

  12. promag commented at 4:32 PM on November 2, 2019: member

    only when the wallet has the avoid_reuse flag set.

    Sounds reasonable to support just that for now.

  13. za-kk cross-referenced this on Nov 2, 2019 from issue gui: grey out used address in address book by za-kk
  14. promag cross-referenced this on Nov 11, 2019 from issue Ability to hide/delete receive addressess by Suffice
  15. fanquake cross-referenced this on Jan 21, 2022 from issue Hide or grey out used addresses by fanquake
  16. fanquake commented at 2:42 AM on January 21, 2022: member

    I've moved this over to the GUI repo: https://github.com/bitcoin-core/gui/issues/528.

  17. fanquake closed this on Jan 21, 2022

  18. bitcoin locked this on Jan 21, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC