doc: Changed miniupnp links to https #17166

pull sandakersmann wants to merge 2 commits into bitcoin:master from sandakersmann:patch-1 changing 1 files +2 −2
  1. sandakersmann commented at 8:51 PM on October 16, 2019: contributor

    Changed http:// to https:// on one link in build-unix.md

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. Changed http:// to https:// on one link in build-unix.md
    Changed http:// to https:// on one link in build-unix.md
    0e3d2d5d58
  4. fanquake added the label Docs on Oct 16, 2019
  5. MarcoFalke renamed this:
    Changed http:// to https:// on one link in build-unix.md
    doc: Changed http:// to https:// on one link in build-unix.md
    on Oct 16, 2019
  6. in doc/build-unix.md:166 in 0e3d2d5d58 outdated 
     163 | @@ -164,7 +164,7 @@ miniupnpc
 164 |  ---------
 165 |  
 166 |  [miniupnpc](http://miniupnp.free.fr/) may be used for UPnP port mapping.  It can be downloaded from [here](
    jonasschnelli commented at 7:01 AM on October 17, 2019:

    Change that link to https://miniupnp.tuxfamily.org/?

    promag commented at 8:45 AM on October 17, 2019:

    Maybe drop the second inline style, like:

    It can be downloaded from https://miniupnp.tuxfamily.org/files/.
    laanwj commented at 7:53 AM on October 18, 2019:

    No need to reformat the style, imo. But if you're changing a line anyway, update both links.

  7. laanwj commented at 8:45 AM on October 17, 2019: member

    ACK (after fixing @jonasschnelli's nit). I don't understand how these keep turning up, though.

  8. promag commented at 8:46 AM on October 17, 2019: member

    ACK after addressing comments.

  9. emilengler commented at 11:11 AM on October 17, 2019: contributor

    ACK

  10. laanwj added the label Waiting for author on Oct 22, 2019
  11. Updated miniupnp link 97174c1298
  12. sandakersmann commented at 12:04 PM on October 24, 2019: contributor

    Fixed @jonasschnelli's nit.

  13. fanquake renamed this:
    doc: Changed http:// to https:// on one link in build-unix.md
    doc: Changed miniupnp links to https
    on Oct 24, 2019
  14. fanquake commented at 12:15 PM on October 24, 2019: member

    @sandakersmann You need to squash your commits, and use a proper commit message. i.e doc: Changed miniupnp links to https.

  15. sandakersmann commented at 12:22 PM on October 24, 2019: contributor

    You need to squash your commits

    Don't know how to do that. I can close this PR and make a new one.

  16. sandakersmann closed this on Oct 24, 2019
  17. sandakersmann cross-referenced this on Oct 24, 2019 from issue doc: Changed miniupnp links to https by sandakersmann
  18. instagibbs commented at 1:01 PM on October 24, 2019: member

    In the future there's no need to open a new PR for a squash/rebase.

    git rebase -i <commit>^ then in interactive rebasing mode you can do things like re-word commits, squash, etc. Then force push to your github branch once you're sure you made the right changes(e.g., git diff shows the code didn't change, and git log shows a single well-commented commit message)

  19. fanquake referenced this in commit d7134ead84 on Oct 24, 2019
  20. laanwj removed the label Waiting for author on Oct 24, 2019
  21. laanwj cross-referenced this on Nov 22, 2019 from issue doc: Changed MiniUPnPc link to https in dependencies.md by sandakersmann
  22. bitcoin locked this on Dec 16, 2021
Contributors
sandakersmanninstagibbsjonasschnellipromaglaanwjemilenglerfanquake
Labels
Docs
Linked (view graph)
#17239 doc: Changed miniupnp links to https#17561 doc: Changed MiniUPnPc link to https in dependencies.md
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC