Qt: possible bug related to immature balance? #1712

issue Diapolo opened this issue on August 23, 2012

Diapolo commented at 1:58 PM on August 23, 2012: none

I was doing some tests on testnet with Bitcoin-Qt and used setgenerate true 4, to get some coins. After a short time the client displayed a balance of 50 BTC under the immature balance display. After restarting the client the display has gone and I also don't see a transaction on the overview page.

When using listtransactions I see the immature balance.
Diapolo commented at 2:04 PM on August 23, 2012: none

I was using https://download.visucore.com/bitcoin/bitcoin-qt-20120823.zip, which @laanwj created for a stack-protector test-setup.

Interesting find now is, that my own builds, which include #1479, are working and display the immature balance directly after client startup ... forget that I re-tested laanwjs build and now the transaction and balance is displayed, too ... very strange.
laanwj commented at 8:00 PM on August 23, 2012: member

It would have shown up after "confirmations: 2" AFAIK this is on purpose, see TransactionRecord::showTransaction.
Diapolo commented at 8:48 PM on August 23, 2012: none

Now it's clear, why my own build containing #1479 showed up the balance (left side on the overview window) imediately, as I use bool IsInMainChain() const { return GetDepthInMainChain() > 0; } instead of GetDepthInMainChain() < 2.

I'm just asking, what is the right approach here. I see the transaction via RPC and via GUI we special case it ... I have a tendency to say I dislike that GUI behavior. What do you think?
laanwj commented at 6:01 AM on August 24, 2012: member

@luke-jr also wants to change that, to show mined transactions at depth 1 instead of depth 2.

I tend to agree this time. Especially as no one clueless is solo-mining anymore, the current threshold is probably overprotective.
Diapolo commented at 6:07 AM on August 24, 2012: none

Sounds good to me, I'll create a small patch to change that.
Diapolo cross-referenced this on Aug 24, 2012 from issue Qt: show mined transactions at depth 1 by Diapolo
laanwj commented at 7:42 AM on September 20, 2012: member

#1717 is merged, closing this
laanwj closed this on Sep 20, 2012
suprnurd referenced this in commit 2144dae915 on Dec 5, 2017
ryanofsky cross-referenced this on Dec 13, 2019 from issue rpc: add extensive file checks for dumptxoutset and dumpwallet by brakmic
bitcoin locked this on Sep 8, 2021

Contributors

#1479 add CWalletTx::GetImmatureCredit() and use it in CWallet::GetImmatureBalance()#1717 Qt: show mined transactions at depth 1 #17623 rpc: add extensive file checks for dumptxoutset and dumpwallet