build: depends macOS: point --sysroot to SDK #17118

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2019/10/macos-sysroot changing 1 files +2 −2
  1. Sjors commented at 2:08 PM on October 12, 2019: member

    Fixes errors like fatal error: 'unistd.h' file not found when building depends on macOS.

    Replaces #14352 (which doesn't work on Catalina).

  2. [build] depends macOS: point --sysroot to SDK a0daea459c
  3. Sjors cross-referenced this on Oct 12, 2019 from issue doc: mention that macOS system headers now require manual installation by fanquake
  4. fanquake added the label Build system on Oct 12, 2019
  5. fanquake added the label macOS on Oct 12, 2019
  6. fanquake renamed this:
    [build] depends macOS: point --sysroot to SDK
    build: depends macOS: point --sysroot to SDK
    on Oct 12, 2019
  7. Sjors cross-referenced this on Oct 12, 2019 from issue macOS Catalina by Sjors
  8. MarcoFalke added the label Needs gitian build on Oct 12, 2019
  9. in depends/builders/darwin.mk:14 in a0daea459c 
       9 | @@ -10,8 +10,8 @@ build_darwin_SHA256SUM=shasum -a 256
  10 |  build_darwin_DOWNLOAD=curl --location --fail --connect-timeout $(DOWNLOAD_CONNECT_TIMEOUT) --retry $(DOWNLOAD_RETRIES) -o
  11 |  
  12 |  #darwin host on darwin builder. overrides darwin host preferences.
  13 | -darwin_CC=$(shell xcrun -f clang) -mmacosx-version-min=$(OSX_MIN_VERSION)
  14 | -darwin_CXX:=$(shell xcrun -f clang++) -mmacosx-version-min=$(OSX_MIN_VERSION) -stdlib=libc++
  15 | +darwin_CC=$(shell xcrun -f clang) -mmacosx-version-min=$(OSX_MIN_VERSION) --sysroot $(shell xcrun --show-sdk-path)
  16 | +darwin_CXX:=$(shell xcrun -f clang++) -mmacosx-version-min=$(OSX_MIN_VERSION) -stdlib=libc++ --sysroot $(shell xcrun --show-sdk-path)
    emilengler commented at 7:36 PM on October 12, 2019:

    Why executing shell? Is it really necessary? The command should be also executed without shell (at least on my linux + zsh)

    Sjors commented at 8:01 PM on October 12, 2019:

    I just copied the pattern @theuni used from other places in that file.

  10. DrahtBot commented at 2:43 AM on October 14, 2019: contributor

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 561a7d30478b82f5d46dcf0f16e864a9608004f4 (master):

    Gitian builds for commit 37adf88b0c4b644d7feac57429dca4f4791f2fd1 (master and this pull):

  11. DrahtBot removed the label Needs gitian build on Oct 14, 2019
  12. Sjors commented at 6:53 AM on October 14, 2019: member

    I'm able to run QT from bitcoin-0.19.99-osx64.tar.gz on macOS 10.15

  13. jonasschnelli commented at 1:23 PM on October 15, 2019: contributor

    utACK a0daea459cf4812fbdda9a7ead131a73f5856c09

  14. laanwj referenced this in commit 4cfb6738e8 on Oct 16, 2019
  15. laanwj merged this on Oct 16, 2019
  16. laanwj closed this on Oct 16, 2019
  17. Sjors deleted the branch on Oct 16, 2019
  18. UdjinM6 referenced this in commit 6472f9cef5 on Oct 17, 2019
  19. UdjinM6 referenced this in commit 0f7d8f8983 on Oct 17, 2019
  20. UdjinM6 referenced this in commit 40ef0f76a5 on Oct 19, 2019
  21. codablock referenced this in commit 55a529bdd6 on Nov 18, 2019
  22. Sjors cross-referenced this on Nov 19, 2019 from issue [WIP] 64 bit iOS device support by Sjors
  23. codablock referenced this in commit ad720eef19 on Nov 19, 2019
  24. MIPPL referenced this in commit 25d33a412b on Nov 24, 2019
  25. deadalnix referenced this in commit 137cade69c on Apr 3, 2020
  26. MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
  27. ftrader referenced this in commit d4479779e3 on Aug 17, 2020
  28. ckti referenced this in commit 334a443f03 on Mar 28, 2021
  29. furszy cross-referenced this on Apr 28, 2021 from issue [build] depends macOS: point --sysroot to SDK by furszy
  30. fanquake cross-referenced this on Apr 28, 2021 from issue build: use `-isysroot` over `--sysroot` on macOS by fanquake
  31. random-zebra referenced this in commit 176f387f23 on Apr 29, 2021
  32. fanquake referenced this in commit bb11a988fa on May 1, 2021
  33. sidhujag referenced this in commit 788d32deca on May 1, 2021
  34. lyricidal cross-referenced this on Jun 15, 2021 from issue [Upstream] [build] depends macOS: point --sysroot to SDK by lyricidal
  35. bitcoin locked this on Dec 16, 2021
Contributors
SjorsemilenglerDrahtBotjonasschnelli
Labels
macOSBuild system
Linked (view graph)
#12557 [WIP] 64 bit iOS device support #14352 doc: mention that macOS system headers now require manual installation#16387 macOS Catalina#21793 build: use `-isysroot` over `--sysroot` on macOS
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC