build: `make dist` uses `git archive` #17104

pull ch4ot1c wants to merge 6 commits into bitcoin:master from ch4ot1c:build/archive-dist changing 3 files +34 −96
  1. ch4ot1c commented at 10:37 PM on October 10, 2019: contributor

    Changes make dist to use git archive instead of its default approach ,EXTRA_DIST.

    The clientversion.cpp version suffix is set to the commit hash of HEAD. There are additional files that are appended beyond this, namely configure and other autotools generated files. The .git directory is not included. Target dist: is used without a dist-hook:.

    ./autogen.sh && ./configure && make dist

    Lastly, simplifies the layout of Makefile.am.

    Note - MacOS would need gtar to use tar --transform for appending the autotools generated files in a prefixed way (an alternate approach). This PR uses git add -f instead.

  2. ch4ot1c cross-referenced this on Oct 10, 2019 from issue Generate release tarball with git archive by MarcoFalke
  3. luke-jr commented at 10:39 PM on October 10, 2019: member

    Concept ACK, but the distfile needs to include autogen-generated files.

    And I don't see why it should be running submodules' make dists...

  4. fanquake added the label Build system on Oct 10, 2019
  5. ch4ot1c commented at 11:00 PM on October 10, 2019: contributor

    I agree, for GNU conformance and support for exotic systems.

    Moved the univalue issue+pr to its upstream repo.

  6. DrahtBot commented at 1:04 AM on October 11, 2019: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17091 (tests: Add test for loadblock option and linearize scripts by fjahr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. DrahtBot added the label Needs rebase on Oct 11, 2019
  8. ch4ot1c force-pushed on Oct 20, 2019
  9. ch4ot1c force-pushed on Oct 20, 2019
  10. build: Simplify Makefile.am
    - Remove `EXTRA_DIST` entries
- Delineate MacOS and Windows sections
- Use `WIN_` prefix consistently
    dc504f2367
  11. build: Add distdir / extracted archive to .gitignore c261bd5122
  12. ch4ot1c force-pushed on Oct 20, 2019
  13. build: `make dist` uses `git archive`
    Keeps its behavior:

- Sets version in src/clientversion.cpp to HEAD commit
- Adds autotools-generated files like `configure`
    6e7ef967ab
  14. ch4ot1c force-pushed on Oct 20, 2019
  15. DrahtBot removed the label Needs rebase on Oct 20, 2019
  16. ch4ot1c renamed this:
    [WIP] build: `make dist` uses `git archive`
    build: `make dist` uses `git archive`
    on Oct 20, 2019
  17. build: Remove phony dist, formatting 3ee34aeb0c
  18. build: Use abs_top_srcdir to find genbuild.sh 91d8c9e7cb
  19. build: Use abs_top_builddir to find genbuild.sh c4703c2212
  20. DrahtBot commented at 10:48 AM on October 23, 2019: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase

  21. DrahtBot added the label Needs rebase on Oct 23, 2019
  22. laanwj added this to the milestone 0.20.0 on Nov 18, 2019
  23. laanwj commented at 1:27 PM on November 18, 2019: member

    Would be nice to have this in 0.20.0.

  24. hebasto commented at 11:29 AM on March 10, 2020: member

    @ch4ot1c Are you still working on this?

  25. laanwj added the label Up for grabs on Mar 11, 2020
  26. laanwj commented at 5:46 PM on March 11, 2020: member

    Labeling this "up for grabs". It'd be nice to have this for 0.20.

  27. hebasto cross-referenced this on Mar 12, 2020 from issue build: Use git archive as source tarball by hebasto
  28. fanquake removed the label Needs rebase on Mar 12, 2020
  29. fanquake removed the label Up for grabs on Mar 12, 2020
  30. fanquake closed this on Mar 12, 2020
  31. fanquake removed this from the milestone 0.20.0 on Mar 12, 2020
  32. laanwj referenced this in commit baa72cd9a2 on Mar 25, 2020
  33. sidhujag referenced this in commit 56ca0913fc on Mar 28, 2020
  34. UdjinM6 referenced this in commit 98417ecad2 on Oct 23, 2021
  35. UdjinM6 referenced this in commit 9e85411dc7 on Oct 23, 2021
  36. UdjinM6 referenced this in commit 83cbc3c811 on Dec 4, 2021
  37. bitcoin locked this on Feb 15, 2022
Contributors
ch4ot1cluke-jrDrahtBotlaanwjhebasto
Labels
Build system
Linked (view graph)
#16734 Generate release tarball with git archive#18331 build: Use git archive as source tarball
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC