build: Add README.md to DIST target #17097

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1909-buildDocDist changing 1 files +4 −1
  1. MarcoFalke commented at 2:51 PM on October 10, 2019: member

    This is required because our release tarball is generated by listing each needed file. See: #16734

    Should fix the failing builds after commit 9b4dfec831e6c20ce06c40412a692315b482e456

  2. MarcoFalke added the label Build system on Oct 10, 2019
  3. MarcoFalke added the label Needs gitian build on Oct 10, 2019
  4. MarcoFalke commented at 2:52 PM on October 10, 2019: member

    cc @dongcarl

  5. build: Add README.md to DIST target fa91590a74
  6. MarcoFalke force-pushed on Oct 10, 2019
  7. laanwj commented at 5:30 PM on October 10, 2019: member

    We didn't even include README.md?!? I guess it needs doc/README_windows.txt as well (or isn't this needed for windows)

  8. MarcoFalke commented at 5:34 PM on October 10, 2019: member

    This whole concept of explicitly listing each and every file manually (or with a fragile wildcard) is an obvious sisyphean task. I'd say all we need to do is run git archive and be done with it forever, see #16734, #6753, #11530 ...

  9. laanwj commented at 6:09 PM on October 10, 2019: member

    I agree, I've never been a fan of it. I don't think we have any files in the git repository we don't want to ship in the source tarball.

  10. MarcoFalke cross-referenced this on Oct 10, 2019 from issue Generate release tarball with git archive by MarcoFalke
  11. DrahtBot commented at 1:07 AM on October 11, 2019: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17104 ([WIP] build: make dist uses git archive by ch4ot1c)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  12. DrahtBot commented at 3:03 PM on October 11, 2019: contributor

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit d5a770b70d55a5874fbd7796a171de22abbbd342 (master):

    Gitian builds for commit 9bbeb37b1fc067781eafcd4e7d4d6d6ccdc7fd05 (master and this pull):

  13. DrahtBot removed the label Needs gitian build on Oct 11, 2019
  14. MarcoFalke commented at 5:34 PM on October 11, 2019: member

    This has no review, and is my own pull request. Though, it fixes the gitian build, so I am just going to merge this.

  15. MarcoFalke commented at 5:34 PM on October 11, 2019: member

    or maybe @fanquake can take a look?

  16. fanquake approved
  17. fanquake commented at 6:05 PM on October 11, 2019: member

    ACK fa91590a74985ff321000864ab3e8ef7414d84eb - just checked that README.md is present inside the tarball after running make dist.

  18. MarcoFalke commented at 6:22 PM on October 11, 2019: member

    I checked that the readme is also in https://drahtbot.space/gitian/bitcoin/bitcoin/9bbeb37b1fc067781eafcd4e7d4d6d6ccdc7fd05/bitcoin-0.19.99.tar.gz

  19. MarcoFalke referenced this in commit f4d93078dd on Oct 11, 2019
  20. MarcoFalke merged this on Oct 11, 2019
  21. MarcoFalke closed this on Oct 11, 2019
  22. MarcoFalke deleted the branch on Oct 11, 2019
  23. sidhujag referenced this in commit bba1991b59 on Oct 11, 2019
  24. hebasto cross-referenced this on Mar 12, 2020 from issue build: Use git archive as source tarball by hebasto
  25. laanwj referenced this in commit baa72cd9a2 on Mar 25, 2020
  26. sidhujag referenced this in commit 56ca0913fc on Mar 28, 2020
  27. MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
  28. MarkLTZ referenced this in commit 04df2f99be on Apr 19, 2020
  29. Fuzzbawls cross-referenced this on Jun 24, 2021 from issue [Build][Cleanup] Tidy up the gitian build descriptors by Fuzzbawls
  30. random-zebra referenced this in commit 3614de632e on Jul 19, 2021
  31. UdjinM6 referenced this in commit 98417ecad2 on Oct 23, 2021
  32. UdjinM6 referenced this in commit 9e85411dc7 on Oct 23, 2021
  33. UdjinM6 referenced this in commit 83cbc3c811 on Dec 4, 2021
  34. bitcoin locked this on Dec 16, 2021
Contributors
MarcoFalkelaanwjDrahtBotfanquake
Labels
Build system
Linked (view graph)
#6753 Release tarball missing many files from git source#11530 Add share/rpcuser to dist. source code archive#16734 Generate release tarball with git archive#18331 build: Use git archive as source tarball
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC