Pass fuzzing inputs as constant references.
Split out from #17009 as suggested by MarcoFalke in #17009 (review).
tests: Pass fuzzing inputs as constant references #17069
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:readonly-fuzzer-inputs changing 4 files +5 −4-
practicalswift commented at 8:53 AM on October 7, 2019: contributor
-
tests: Pass fuzzing inputs as constant references ffa2221256
- DrahtBot added the label Tests on Oct 7, 2019
- MarcoFalke added the label Refactoring on Oct 7, 2019
-
MarcoFalke commented at 1:24 PM on October 7, 2019: member
ACK ffa22212560c9e7a8692cb8982d9b3b507ee9af1
This is just stylistic refactoring, because a copy is created either way. Though, it seems fine to do this change, even if we were to switch to a different class (like https://cs.chromium.org/chromium/src/third_party/libFuzzer/src/utils/FuzzedDataProvider.h?rcl=b9f51dc8c98065df0c8da13c051046f5bab833db), the input data remains read-only.
- MarcoFalke referenced this in commit febc31c641 on Oct 7, 2019
- MarcoFalke merged this on Oct 7, 2019
- MarcoFalke closed this on Oct 7, 2019
- sidhujag referenced this in commit a167684c20 on Oct 7, 2019
- MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
- deadalnix referenced this in commit efa7a3323c on Jun 26, 2020
- practicalswift deleted the branch on Apr 10, 2021
- kwvg referenced this in commit 6eb80ee0f0 on Aug 2, 2021
- kwvg referenced this in commit 2f127d3a74 on Aug 5, 2021
- kwvg referenced this in commit 2829b538b7 on Aug 5, 2021
- kwvg referenced this in commit 2008624592 on Aug 5, 2021
- PastaPastaPasta referenced this in commit ad0a4c938c on Aug 6, 2021
- kwvg referenced this in commit b32be51589 on Aug 8, 2021
- kwvg referenced this in commit dd782444bf on Aug 11, 2021
- PastaPastaPasta referenced this in commit 90e7119a8b on Aug 11, 2021
- 5tefan referenced this in commit 88cc92f8d8 on Aug 12, 2021
- bitcoin locked this on Aug 18, 2022
Contributors
Labels