test: Bump dummy scriptPubKey size after default address change #17043

issue MarcoFalke opened this issue on October 3, 2019
  1. MarcoFalke commented at 6:57 PM on October 3, 2019: member

    fecc1be23143476b981352e8516cf9cce0450d62 changed the default addresstype, which means that functional tests that create tx sending to short scriptPubKeys such as OP_TRUE might violate the "tx-too-small" policy rule. See the added TODOs in the functional tests in that commit for reference.

    The TODOs can be solved by defining a large enough dummy scriptPbuKey (maybe as a constant, 64 bytes should be long enough) and using that over OP_TRUE or hardcoded in-line CScript([b'a' * 35]).

  2. MarcoFalke added the label Tests on Oct 3, 2019
  3. MarcoFalke added the label good first issue on Oct 3, 2019
  4. MarcoFalke added the label Hacktoberfest on Oct 3, 2019
  5. theStack referenced this in commit c41978c8c7 on Oct 11, 2019
  6. theStack cross-referenced this on Oct 11, 2019 from issue test: fix "tx-size-small" errors after default address change by theStack
  7. theStack referenced this in commit f2240dbcda on Oct 13, 2019
  8. theStack referenced this in commit 32d665c265 on Oct 14, 2019
  9. MarcoFalke referenced this in commit 6c7da0736d on Oct 14, 2019
  10. MarcoFalke closed this on Oct 14, 2019

  11. sidhujag referenced this in commit 16ff5d6526 on Oct 15, 2019
  12. theStack cross-referenced this on Oct 22, 2019 from issue test: use default address type (bech32) for wallet_bumpfee tests by theStack
  13. bitcoin locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC