ADD_ONION assumes bitcoind to reside in hardcoded 127.0.0.1 #16693

https://github.com/bitcoin/bitcoin/blob/d72758c3f6c34cd835f5de3efc230964f3b1ea56/src/torcontrol.cpp#L539

If a user is running Tor proxy outside localhost (perhaps on other host inside LAN or in containerised environment) , the automatic creation of onion services ends up creating an onion service listening to hardcored 127.0.0.1 address on the Tor proxy's host instead of the private address of the bitcoind – effectively running an empty onion service listening the Tor proxy's localhost.

Good point but do people actually run Tor outside? Everyone who really wants to protect his privacy through Tor would never do this

Good point but do people actually run Tor outside?

I'd say it's relatively common to have a separate Tor proxy in your LAN somewhere, not necessarily on the same host. Especially if you're running several hidden services in separate containers or perhaps routing traffic of all your devices through torified Raspberry Pi, for example.

@henrikuittinen Sure, but how would you be using the Tor control interface in that case?

@henrikuittinen Sure, but how would you be using the Tor control interface in that case?

Through -torcontrol=<ip>:<port> and -torpassword=<pass>. It connects perfectly and creates a hidden service, but assumes the bitcoind is in 127.0.0.1 – which is of course hardcoded at the moment.

Oh, interesting. That sounds like a bug.

Yeah, it's right here: https://github.com/bitcoin/bitcoin/blob/d72758c3f6c34cd835f5de3efc230964f3b1ea56/src/torcontrol.cpp#L539

I reckon instead of hardcoding 127.0.0.1 it should take in GetBindAddress().

Wow, I've spent so much time trying to figure out why the bitcoind I run in a container doesn't want to work with Tor on host, and inventing dirty hacks to go around that 😬. Needless to say, glad this issue exists :).

@henrikuittinen Mind testing #19991?

@henrikuittinen Mind testing #19991?

Unfortunately I don't have this setup anymore. Thanks for the PR though!