Fix UpdateTip LogPrintf() whitespaces #16657

pull cvasqxz wants to merge 3 commits into bitcoin:master from cvasqxz:master changing 1 files +8 −4
  1. cvasqxz commented at 4:05 PM on August 19, 2019: none

    Added whitespaces into UpdateTip's logprintf to improve code readability.

  2. Fix UpdateTip LogPrintf() whitespaces e3e548fe5a
  3. emilengler commented at 4:10 PM on August 19, 2019: contributor

    Concept ACK e3e548f

  4. Added missing Continued tag into UpdateTip logprintf 71fb474c80
  5. Removed newlines before and after logprintf 9d73500a13
  6. MarcoFalke commented at 5:24 PM on August 19, 2019: member

    Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:

    • Time spent on review
    • Accidental introduction of bugs
    • (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.

    For more information about refactoring changes and stylistic cleanup, see

    Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

    Let me know if you have any questions.

  7. MarcoFalke closed this on Aug 19, 2019

  8. bitcoin locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC