build: macOS toolchain update #16392

fanquake commented at 6:58 AM on July 15, 2019: member

TLDR: This updates our macOS toolchain to use a newer version of Clang, cctools (including new dependency on libtapi), LD64 and the macOS SDK.

I've been testing depends builds (HOST=x86_64-apple-darwin16) inside a Debian Buster Docker container, and running the resultant bitcoind and bitcoin-qt binaries on a macOS 10.14.4 system. The .dmg generated by a make deploy also mounts correctly on the same macOS system.

Clang

Upgraded from 3.7.1 to 6.0.1

cctools

cctools 877.8 -> 921
LD64 253.9 -> 409.12
TAPI 1000.10.8

See tpoechtrager/cctools-port and tpoechtrager/apple-libtapi.

macOS SDK

Upgraded from building against the macOS 10.11 SDK to the macOS 10.14 SDK.

TODO

Make the 10.14 SDK available to Travis.

Fixes: #16052 Closes: #14797

fanquake added the label macOS on Jul 15, 2019

fanquake added the label Build system on Jul 15, 2019

fanquake added the label Needs gitian build on Jul 15, 2019

fanquake added the label Needs Conceptual Review on Jul 15, 2019

fanquake added this to the milestone 0.19.0 on Jul 15, 2019

fanquake requested review from theuni on Jul 15, 2019

fanquake requested review from dongcarl on Jul 15, 2019

DrahtBot commented at 7:21 AM on July 15, 2019: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#17919 (depends: Allow building with system clang by dongcarl)
#15441 ([doc] build: warn against spaces in working directory by Sjors)
#12557 ([WIP] 64 bit iOS device support by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake force-pushed on Jul 15, 2019

in depends/packages/native_libdmg-hfsplus.mk:3 in 31f7825155 outdated

   0 | @@ -1,8 +1,8 @@
   1 |  package=native_libdmg-hfsplus
   2 | -$(package)_version=0.1
   3 | -$(package)_download_path=https://github.com/theuni/libdmg-hfsplus/archive
   4 | -$(package)_file_name=libdmg-hfsplus-v$($(package)_version).tar.gz
   5 | -$(package)_sha256_hash=6569a02eb31c2827080d7d59001869ea14484c281efab0ae7f2b86af5c3120b3
   6 | +$(package)_version=3e5fd3fb56bc9ff03beb535979e33dcf83fe1f70
   7 | +$(package)_download_path=https://github.com/fanquake/libdmg-hfsplus/archive

dongcarl commented at 8:02 PM on July 15, 2019:

Any reason why we're using your fork instead of upstream?

fanquake commented at 1:27 AM on July 16, 2019:

I'm still applying one commit on top of upstream: https://github.com/fanquake/libdmg-hfsplus/commit/3e5fd3fb56bc9ff03beb535979e33dcf83fe1f70

Although now that there's only one commit left we could put the patch in depends and point back to upstream if you'd prefer?

theuni commented at 5:55 PM on August 2, 2019:

Although now that there's only one commit left we could put the patch in depends and point back to upstream if you'd prefer?

+1

DrahtBot removed the label Needs gitian build on Jul 15, 2019

theuni commented at 9:23 PM on July 22, 2019: member

Nice! Concept ack.

+1 for a new prog to replace our dmg hacks. I think that might also mean that we could get rid of CMake.

Will review in depth.

bitcoin deleted a comment on Jul 22, 2019

practicalswift commented at 11:29 PM on July 22, 2019: contributor

Concept ACK

DrahtBot added the label Needs rebase on Jul 25, 2019

DrahtBot commented at 3:33 AM on July 25, 2019: contributor

Needs rebase

Sjors commented at 9:02 AM on July 25, 2019: member

Tested building depends on macOS 10.14.6 Mojave. I still had to do this annoying workaround:

open /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg

And building protobuf fails: log

If I remove protobuf and native_protobuf it does build. I can then compile QT:

./autogen.sh
./configure --prefix=`pwd`/depends/x86_64-apple-darwin18.7.0 --disable-bip70
make

This works, but I get a flood of warnings at the end: log

Will test on macOS 10.15 Catalina later.

We should backport this to 0.18 given #16387 and ideally do a 0.18.2 tag before Catalina is out (September or October). Our 0.19 release is scheduled for November #15940, so otherwise there's no tag to build from.

Concept ACK on bumping macOS from 10.10 to 10.12, though a small percentage of users would have to stay on the 0.18 branch (the last tag before backport).

The bottleneck for upgrading macOS is hardware, and that's pretty durable. Here are the minimum specs for 10.10: <img width="871" alt="system 10 10" src="https://user-images.githubusercontent.com/10217/61854056-a01fc780-aebd-11e9-8e25-76af45077cf8.png">

Minimum specs for 10.12: <img width="576" alt="system 10 12" src="https://user-images.githubusercontent.com/10217/61854067-a3b34e80-aebd-11e9-8f8e-936a0cecb080.png">

Some refurbished machines for sale: <img width="480" alt="refurbished" src="https://user-images.githubusercontent.com/10217/61854110-b29a0100-aebd-11e9-9dff-a49f882d018b.png">

Some second hand machines at an even lower price point still work: <img width="621" alt="macbook pro 2011" src="https://user-images.githubusercontent.com/10217/61854440-600d1480-aebe-11e9-9d84-37aa84dfc2e0.png">

Some don't: <img width="626" alt="macbook pro 2009" src="https://user-images.githubusercontent.com/10217/61854428-584d7000-aebe-11e9-8495-f26884bd86e1.png">

fanquake commented at 12:56 AM on July 26, 2019: member

I still had to do this annoying workaround:

Yep, that isn't new with this change, but may go away if we can remove any reliance on having the headers in the now deprecated location. See details in the Command Line Tools section of the Xcode 10 release notes.

If I remove protobuf and native_protobuf it does build. I can then compile QT:

Did you try to build depends before installing the new headers? If you make clean in depends, then try rebuilding as usual it should work. Nothing Protobuf related is being changed in this PR.

fanquake force-pushed on Jul 26, 2019

fanquake removed the label Needs rebase on Jul 26, 2019

jonasschnelli commented at 8:44 AM on July 26, 2019: contributor

Concept ACK. Unsure about the timing, if its already the time to drop 10.10 & 10.11 since 10.11 was released on Oct 2015. According to statista, in April 2019, 10.10 and 10.11 makes about 16% of mac installations. (https://www.statista.com/statistics/944559/worldwide-macos-version-market-share/)

Aidium publishes their update stats and it looks like, >10% was using 10.11 this week. https://www.adium.im/sparkle/

It'd say we wait with this.

Sjors commented at 12:32 PM on July 26, 2019: member

Did you try to build depends before installing the new headers? If you make clean in depends

I thought I did, but maybe not. I just tried make clean and now protobuf indeed just buids (on 536034b).

It'd say we wait with this.

If it doesn't break anything else, maybe we can do this bump when we bump QT to 5.12 (LTS)?

fanquake force-pushed on Jul 30, 2019

fanquake commented at 2:05 AM on July 30, 2019: member

Updated to add some documentation (Linux) for the macOS 10.14 SDK extraction. This doesn't have to be the final docs, but should be useful for someone on a Linux machine wanting to extract the SDK and test this PR.

It'd say we wait with this.

We don't have to bump the minimum to 10.12 right now. We could do 10.11, or potentially leave it at 10.10 assuming there aren't any issues using the new SDK. Regardless, I'd like the rest of the changes (or at least the new Clang) to make it into v0.19.0, so that building for macOS isn't broken on Debian Buster #16052.

Sjors commented at 5:19 PM on August 1, 2019: member

From Apple: "All Macintosh computers that can run Mountain Lion, Mavericks, or Yosemite can run El Capitan" (10.11). I suspect many people just don't realize they can upgrade.

I managed to build depends on macOS 10.14.6 (Mojave) with the minimum version set to 10.10

[...] may go away if we can remove any reliance on having the headers in the now deprecated location

That means this PR is not enough to support Catalina, at least not without some other workaround.

in depends/hosts/darwin.mk:4 in 7decfd42ef outdated

   0 | @@ -1,7 +1,7 @@
   1 |  OSX_MIN_VERSION=10.12
   2 |  OSX_SDK_VERSION=10.14
   3 |  OSX_SDK=$(SDK_PATH)/MacOSX$(OSX_SDK_VERSION).sdk
   4 | -LD64_VERSION=253.9
   5 | +LD64_VERSION=409.12

theuni commented at 6:02 PM on August 2, 2019:

All of the LD64_VERSION stuff (used by darwin_CC and darwin_CXX) stuff may be unnecessary now. I believe "-mlinker-version" was a hack around a bug that may have now been fixed.

Could you try removing the -mlinker-version=... and seeing if the build still succeeds?

fanquake commented at 3:49 AM on August 5, 2019:

Have combined your LD64 suggestions into the cctools commit.

in depends/packages/native_cctools.mk:37 in 7decfd42ef outdated

  36 |    echo "$($(package)_clang_sha256_hash)  $($(package)_source_dir)/$($(package)_clang_file_name)" >> $($(package)_extract_dir)/.$($(package)_file_name).hash && \
  37 | +  echo "$($(package)_libtapi_sha256_hash)  $($(package)_source_dir)/$($(package)_libtapi_file_name)" >> $($(package)_extract_dir)/.$($(package)_file_name).hash && \
  38 |    $(build_SHA256SUM) -c $($(package)_extract_dir)/.$($(package)_file_name).hash && \
  39 | +  mkdir -p libtapi installed_libtapi && \
  40 | +  tar --no-same-owner --strip-components=1 -C libtapi -xf $($(package)_source_dir)/$($(package)_libtapi_file_name) && \
  41 | +  INSTALLPREFIX=$($(package)_extract_dir)/installed_libtapi ./libtapi/build.sh && \

theuni commented at 6:06 PM on August 2, 2019:

The main reason for adding this dependency here rather than separately would be so that we can use our fresh compiler (clang) to build it. The same way we handle cctools.

Unless I'm misunderstanding, the way this is done currently, the system compiler is used. We've headed off a few frustrating incompatibilities by using a fixed compiler for the related toolchain components (cctools) in the past, and I think we should continue that.

Can you move the configure/build around to make that happen? Maybe handle both in _preprocess?

fanquake commented at 3:49 AM on August 5, 2019:

I've switched this around so that libtapi is now being built with our 6.0.1 Clang.

in depends/packages/native_cctools.mk:38 in 7decfd42ef outdated

  40 | +  tar --no-same-owner --strip-components=1 -C libtapi -xf $($(package)_source_dir)/$($(package)_libtapi_file_name) && \
  41 | +  INSTALLPREFIX=$($(package)_extract_dir)/installed_libtapi ./libtapi/build.sh && \
  42 | +  INSTALLPREFIX=$($(package)_extract_dir)/installed_libtapi ./libtapi/install.sh && \
  43 |    mkdir -p toolchain/bin toolchain/lib/clang/6.0.1/include && \
  44 |    tar --no-same-owner --strip-components=1 -C toolchain -xf $($(package)_source_dir)/$($(package)_clang_file_name) && \
  45 |    rm -f toolchain/lib/libc++abi.so* && \

theuni commented at 6:26 PM on August 2, 2019:

Sadly I can't remember why the libc++abi.so removal is needed, maybe the SDK ships with the proper one?

As for dsymutil, that hack was added because the previous cctools didn't ship with one, and some build scripts expect to find it. If the new cctools ships with one, or if whatever required it has been fixed, this can be removed.

fanquake commented at 3:48 AM on August 5, 2019:

Combined your suggestions into the Clang update commit.

in depends/packages/native_cctools.mk:56 in 7decfd42ef outdated

  53 |  $(package)_cxx=$($(package)_extract_dir)/toolchain/bin/clang++
  54 |  endef
  55 |  
  56 |  define $(package)_preprocess_cmds
  57 | -  cd $($(package)_build_subdir); ./autogen.sh && \
  58 | +  cd $($(package)_build_subdir); autoreconf -if && ./autogen.sh && \

theuni commented at 6:26 PM on August 2, 2019:

Isn't this redundant?

fanquake commented at 3:48 AM on August 5, 2019:

Have dropped this entire line.

in depends/packages/native_cctools.mk:67 in 7decfd42ef outdated

  66 | @@ -52,6 +67,9 @@ endef
  67 |  
  68 |  define $(package)_stage_cmds
  69 |    $(MAKE) DESTDIR=$($(package)_staging_dir) install && \
  70 | +  mkdir -p $($(package)_staging_prefix_dir)/lib/ && \
  71 | +  cd $($(package)_extract_dir)/installed_libtapi && \
  72 | +  cp lib/libtapi.so.6 $($(package)_staging_prefix_dir)/lib/ && \

theuni commented at 6:28 PM on August 2, 2019:

We want this built statically if possible, otherwise this introduces a (rather unnecessary) LDPATH runtime requirement. Does build.sh have static lib support?

theuni commented at 6:32 PM on August 2, 2019: member

For the most part this looks great. I've added a few notes around libtapi which still needs a little work IMO.

I've not tried building yet, I'll work on getting an SDK extracted.

theuni commented at 8:47 PM on August 2, 2019: member

I tested a few of my cleanup suggestions above, and they seem to work fine. Feel free to pull the top two from here: https://github.com/theuni/bitcoin/commits/16392, or adapt them into your commits however's easiest.

fanquake force-pushed on Aug 5, 2019

fanquake commented at 3:50 AM on August 5, 2019: member

@theuni I've incorporated some of your suggestions (trimming the LD64 stuff, and the clang hacks) and added you as co-author to the relevant commits.

We are now pointing back to upstream libdmg-hfsplus, with a single patch included in depends.

We are also now pointing back to the upstream cctools-port repo.

libtapi is now being built with our 6.0.1 Clang and I've removed one of the intermediate directories I was creating.

I still need to address:

We want this built statically if possible, otherwise this introduces a (rather unnecessary) LDPATH runtime requirement. Does build.sh have static lib support?

Sjors commented at 9:58 AM on August 5, 2019: member

Building depends on macOS 10.14.6 Mojave still works as of 97b3349.

fanquake force-pushed on Aug 6, 2019

fanquake commented at 6:02 AM on August 6, 2019: member

I've updated this to pull the macOS DMG notes (with some minor changes) out of build-osx.md and put them in the contrib/macdeploy/README.md with the other deployment notes. I've also added a new section on extracting the new SDK when your using macOS.

fanquake cross-referenced this on Aug 12, 2019 from issue depends: Bump QT to LTS release 5.9.8 by THETCR

BlockMechanic commented at 5:50 AM on August 12, 2019: contributor

:+1: Concept ACK, this may help alleviate issues i've had trying to create build bitcoin-qt on aarch64.

DrahtBot added the label Needs rebase on Aug 19, 2019

fanquake force-pushed on Aug 20, 2019

fanquake removed the label Needs rebase on Aug 20, 2019

laanwj added this to the "Chasing Concept ACK" column in a project

hebasto cross-referenced this on Sep 2, 2019 from issue gui: Remove needless GCC diagnostic pragma by hebasto

laanwj commented at 11:47 AM on September 5, 2019: member

I think it's too late to do this for 0.19, might want to bump the milestone to 0.20 and then do it early in the merge window?

jonasschnelli commented at 1:27 PM on September 5, 2019: contributor

I also think it is too early for no good reason.

According to statista, in April 2019, 10.10 and 10.11 makes about 16% of mac installations.

fanquake commented at 12:51 AM on September 10, 2019: member

I think it's too late to do this for 0.19,

Ok. I've punted this to v0.20.0, for an early merge. Will address remaining comments here shortly.

fanquake removed this from the milestone 0.19.0 on Sep 10, 2019

fanquake added this to the milestone 0.20.0 on Sep 10, 2019

DrahtBot added the label Needs rebase on Sep 17, 2019

Sjors cross-referenced this on Sep 19, 2019 from issue WIP QT Android Build by BlockMechanic

fanquake force-pushed on Sep 23, 2019

fanquake removed the label Needs rebase on Sep 23, 2019

DrahtBot added the label Needs rebase on Oct 2, 2019

laanwj commented at 5:23 PM on October 2, 2019: member

Ok. I've punted this to v0.20.0, for an early merge. Will address remaining comments here shortly.

:smiling_imp:

fanquake cross-referenced this on Oct 4, 2019 from issue build: switch to upstream libdmg-hfsplus by fanquake

dongcarl commented at 7:12 PM on October 8, 2019: contributor

Gitian build for 329af88c548ff4afe6fed7fdbad3d39f62044048 is failing for me, tail -n1024 build.log: https://paste.sr.ht/%7Edongcarl/fcafb82a86a68e86c5b29b5e32e00d68211d2661

fanquake commented at 7:13 PM on October 8, 2019: member

@dongcarl Looks like the macOS SDK isn't available?

dongcarl commented at 7:15 PM on October 8, 2019: contributor

@fanquake docker exec -it --user root gitian-target find -name '*.sdk.tar.gz' outputs ./build/MacOSX10.14.sdk.tar.gz

Obtained using cd /Applications && tar -C Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/ -czf MacOSX10.14.sdk.tar.gz MacOSX.sdk after downloading Xcode from App Store

fanquake commented at 7:19 PM on October 8, 2019: member

@dongcarl Has it been untarred inside depends/SDKs?

Every time I've seen fatal error: 'unistd.h' file not found has been because depends can't find the macOS SDK.

dongcarl commented at 7:20 PM on October 8, 2019: contributor

@fanquake Here's what I see inside the docker container:

root@694ebefb6b63:/home/ubuntu/build/bitcoin/depends/SDKs/MacOSX.sdk# ls
Entitlements.plist  Library  SDKSettings.json  SDKSettings.plist  System  usr

dongcarl commented at 7:22 PM on October 8, 2019: contributor

Oh wait... I have too new of an Xcode... It's actually MacOSX10.15.sdk that I tarred up...

fanquake commented at 7:24 PM on October 8, 2019: member

Oh wait... I have too new of an Xcode... It's actually MacOSX10.15.sdk that I tarred up... @dongcarl That would likely actually work fine.

The real problem is that you need to rename the directory to MacOSX10.14.sdk rather than MacOSX.sdk. See how the path is built in depends.

dongcarl commented at 8:30 PM on October 8, 2019: contributor

@fanquake Thanks for offline help for the above. I also ran into another error mentioning libc++abi.so that was solved by readding a previously-removed line:

diff --git a/depends/packages/native_cctools.mk b/depends/packages/native_cctools.mk
index 2371a691b..ecfc6f9d5 100644
--- a/depends/packages/native_cctools.mk
+++ b/depends/packages/native_cctools.mk
@@ -36,6 +36,7 @@ define $(package)_extract_cmds
   tar --no-same-owner --strip-components=1 -C libtapi -xf $($(package)_source_dir)/$($(package)_libtapi_file_name) && \
   mkdir -p toolchain/bin toolchain/lib/clang/6.0.1/include && \
   tar --no-same-owner --strip-components=1 -C toolchain -xf $($(package)_source_dir)/$($(package)_clang_file_name) && \
+  rm -f toolchain/lib/libc++abi.so* && \
   tar --no-same-owner --strip-components=1 -xf $($(package)_source)
 endef

dongcarl commented at 11:23 PM on October 8, 2019: contributor

With these patches, I was able to perform a Gitian build: https://github.com/fanquake/bitcoin/compare/329af88c548ff4afe6fed7fdbad3d39f62044048...dongcarl:2019-10-fixing-fanquake-osx-bump

If @theuni could shed light on the context of f6448f99ef1cb688edffcd4b5934af938b0e228a, we should document it.

dongcarl cross-referenced this on Oct 10, 2019 from issue depends: Eliminate hard dependency on Ubuntu-ABI specific clang by dongcarl

laanwj referenced this in commit d882f63589 on Oct 14, 2019

BlockMechanic commented at 7:29 PM on October 14, 2019: contributor

I do not see an actual change to Qt 5.12 in the PR... is this in preparation ?

Fuzzbawls commented at 11:39 PM on October 14, 2019: contributor

Regarding the bumping of minimum supported macOS (OS X) version: I would say that 10.11 minimum is fine, but 10.12 requires newer CPU based SSE4.1 support that prevent otherwise perfectly viable CPUs (older Xeon CPUs mainly) from upgrading to 10.12.

sidhujag referenced this in commit ecad5267fa on Oct 15, 2019

fanquake force-pushed on Oct 15, 2019

fanquake removed the label Needs rebase on Oct 15, 2019

in contrib/macdeploy/README.md:9 in b052792719 outdated

   8 | +```bash
   9 | +make deploy
  10 | +```
  11 |  
  12 | -This script should not be run manually, instead, after building as usual:
  13 | +During the deployment process, the disk image window will pop up briefly

MarcoFalke commented at 12:33 PM on October 16, 2019:

During the deployment process, the disk image window will pop up briefly

:eyes:

dongcarl commented at 2:21 PM on October 16, 2019: contributor

@fanquake You might want to cherry-pick in my README fixes for your changes here: https://github.com/bitcoin/bitcoin/pull/17099/commits/1250d228e14672e4c2e0c83a6548929749c64ce0

fanquake force-pushed on Oct 16, 2019

fanquake commented at 3:10 PM on October 16, 2019: member

@dongcarl pulled your changes in as part of 1052e1a44e93a3a3cf2fe18a17916ea5f2dbe07f.

dongcarl commented at 3:31 PM on October 16, 2019: contributor

@fanquake Also, as mentioned above, you probably also need f6448f99ef1cb688edffcd4b5934af938b0e228a to fix Gitian builds. :grimacing:

bitcoin deleted a comment on Oct 16, 2019

fanquake force-pushed on Oct 16, 2019

fanquake commented at 3:52 PM on October 16, 2019: member

@dongcarl I've reverted the removal of that line in bf9488b1dd228a011f61ae21a642ee9ce69e03c2 as well updated 9d51eb8cca106ecaf9a05e52e15bfbf93fbde4a8 to point to the latest upstream version of cctools.

dongcarl commented at 3:46 PM on October 17, 2019: contributor

@fanquake Would you say that this is no longer WIP? I'd say it's ready for merge :grimacing:

MarcoFalke commented at 3:49 PM on October 17, 2019: member

Not so fast. Let's fix the travis and DrahtBot failure first. ;)

MarcoFalke commented at 3:49 PM on October 17, 2019: member

https://travis-ci.org/bitcoin/bitcoin/jobs/598728043#L1466

fanquake commented at 3:51 PM on October 17, 2019: member

Would you say that this is no longer WIP? I'd say it's ready for merge 😬

I'll do a final rebase/any cleanup and remove the [WIP] tag.

Not so fast. Let's fix the travis and DrahtBot failure first. ;)

This should just require making the newer SDK available to both.

in .travis.yml:140 in 9d51eb8cca outdated

 156 | @@ -157,6 +157,6 @@ jobs:
 157 |          FILE_ENV="./ci/test/00_setup_env_amd64_nowallet.sh"
 158 |  
 159 |      - stage: test
 160 | -      name: 'macOS 10.10  [GOAL: deploy] [no functional tests]'
 161 | +      name: 'macOS 10.12  [GOAL: deploy] [no functional tests]'

MarcoFalke commented at 3:51 PM on October 17, 2019:

So the minimum macOS version is 10.12, the SDK version is 10.14, and the cross compile target is x86_64-apple-darwin16? This is not confusing at all.

fanquake commented at 3:56 PM on October 17, 2019:

x86_64-apple-darwin16 maps to macOS 10.12, more info here. We're building with the 10.14 SDK, however this can be newer, and is the same as we've been doing in previous releases. i.e using the 10.11 SDK while building for 10.7.

fanquake renamed this:
~~WIP build: macOS toolchain update~~
build: macOS toolchain update
on Oct 17, 2019

fanquake removed the label Needs Conceptual Review on Oct 17, 2019

fanquake removed this from the "Chasing Concept ACK" column in a project

fanquake force-pushed on Oct 17, 2019

in contrib/gitian-build.py:212 in 35250677b3 outdated

 207 | @@ -208,7 +208,7 @@ def main():
 208 |      args.macos = 'm' in args.os
 209 |  
 210 |      # Disable for MacOS if no SDK found
 211 | -    if args.macos and not os.path.isfile('gitian-builder/inputs/MacOSX10.11.sdk.tar.gz'):
 212 | +    if args.macos and not os.path.isfile('gitian-builder/inputs/MacOSX10.14.sdk.tar.gz'):

MarcoFalke commented at 5:25 PM on October 17, 2019:

Should the gitian-build in master support compiling older releases?

dongcarl commented at 6:58 PM on October 17, 2019:

Not sure that's a burden we wanna take on. It's probably going to be more sane for those with that use-case to check out the older tag.

MarcoFalke commented at 12:28 PM on October 18, 2019:

Seems fine

in doc/release-notes.md:55 in 35250677b3 outdated

  54 |  as frequently tested on them.
  55 |  
  56 | -From Bitcoin Core 0.17.0 onwards, macOS versions earlier than 10.10 are no
  57 | -longer supported, as Bitcoin Core is now built using Qt 5.9.x which requires
  58 | -macOS 10.10+. Additionally, Bitcoin Core does not yet change appearance when
  59 | +From 0.19.0 onwards, macOS <10.12 is no longer supported.

MarcoFalke commented at 1:22 PM on October 18, 2019:

From 0.20.0 onwards, macOS <10.12 is no longer supported.

?

MarcoFalke added the label Needs gitian build on Oct 18, 2019

DrahtBot removed the label Needs gitian build on Oct 19, 2019

in depends/hosts/darwin.mk:2 in 6552fbd779 outdated

   0 | @@ -1,4 +1,4 @@
   1 | -OSX_MIN_VERSION=10.10
   2 | +OSX_MIN_VERSION=10.12
   3 |  OSX_SDK_VERSION=10.11

Sjors commented at 9:37 AM on October 21, 2019:

OSX_SDK_VERSION should be 10.14?

fanquake commented at 12:40 PM on October 21, 2019:

Looks like you're commenting on an outdated diff. This is 10.14 in 1728e348c7678504502fc28db109cc870e286695.

in doc/build-osx.md:113 in 6552fbd779 outdated

 109 | @@ -110,7 +110,7 @@ tail -f $HOME/Library/Application\ Support/Bitcoin/debug.log
 110 |  ```
 111 |  
 112 |  ## Notes
 113 | -* Tested on OS X 10.10 Yosemite through macOS 10.14 Mojave on 64-bit Intel
 114 | +* Tested on OS X 10.12 Sierra through macOS 10.14 Mojave on 64-bit Intel

Sjors commented at 9:38 AM on October 21, 2019:

through macOS 10.15 Catalina

in contrib/macdeploy/README.md:1 in 1728e348c7 outdated

   0 | @@ -1,15 +1,135 @@
   1 | -### MacDeploy ###
   2 | +# Mac Deployment

Sjors commented at 10:18 AM on October 21, 2019:

Nit: macOS; more SEO and search friendly

in contrib/macdeploy/README.md:52 in 1728e348c7 outdated

  55 | +xip -x Xcode_10.2.1.xip
  56 | +tar -C Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/ -czf MacOSX10.14.sdk.tar.gz MacOSX.sdk
  57 | +```
  58 | +
  59 | +Our previously used macOS SDK (`MacOSX10.11.sdk`) can be extracted from
  60 | +[Xcode 7.3.1 dmg](https://developer.apple.com/devcenter/download.action?path=/Developer_Tools/Xcode_7.3.1/Xcode_7.3.1.dmg).

Sjors commented at 10:34 AM on October 21, 2019:

Maybe update this URL and move it to the top of this section: https://download.developer.apple.com/Developer_Tools/Xcode_10.3/Xcode_10.3.xip (from July 2019)

In general this section refers to several different versions of Xcode. For SDK 10.14 we need Xcode 10. A more future proof instruction might be :This can be found here: https://developer.apple.com/download/more/ by filtering "xcode 10"

fanquake commented at 12:37 PM on October 21, 2019:

Why update this URL, it's meant to be pointing to the previously used SDK? The link to the newer SDK is later in the file.

Sjors commented at 2:05 PM on October 21, 2019:

Ah ok, let's just drop that altogether then (can be done in a followup, along with bumping xcode 10.2.1 to 10.3 and putting the URL above the place where you need it instead of below).

in contrib/macdeploy/README.md:17 in 1728e348c7 outdated

  20 | -During the process, the disk image window will pop up briefly where the fancy
  21 | -settings are applied. This is normal, please do not interfere.
  22 | +## SDK Extraction
  23 |  
  24 | -When finished, it will produce `Bitcoin-Qt.dmg`.
  25 | +After Xcode version 7.x, Apple started shipping the `Xcode.app` in a `.xip` archive.

Sjors commented at 10:37 AM on October 21, 2019:

Nit: we can lose the historical reference and just say "Xcode.app is packaged in a .xip archive.

Sjors commented at 10:49 AM on October 21, 2019: member

Tested 3525067 on macOS 10.15 Catalina. Although QT depends are built and configure log says checking whether to build Bitcoin Core GUI... yes (Qt5), the configure summary drops it: with gui / qt = no. See configure log.

extract-osx-sdk.sh needs to be updated as (though I've never used it)
macOS deploy instructions still refer to 10.11
there's a reference to MAC_OS_X_VERSION_MIN_REQUIRED > 101100 in optionsdialog.cpp which presumably can be dropped?

fanquake force-pushed on Oct 21, 2019

fanquake commented at 12:47 PM on October 21, 2019: member

Rebased on master and pushed some changes to fix the doc suggestions above.

Although QT depends are built and configure log says checking whether to build Bitcoin Core GUI... yes (Qt5), the configure summary drops it: with gui / qt = no. See configure log.

That's unrelated to this PR. The reason Qt isn't being picked up is in the log: configure: WARNING: PROTOC not found; bitcoin-qt frontend will not be built.

there's a reference to MAC_OS_X_VERSION_MIN_REQUIRED > 101100 in optionsdialog.cpp which presumably can be dropped?

There are multiple similar changes that can be made post this PR, but I'm not going to do them here.

fanquake force-pushed on Oct 21, 2019

Sjors commented at 4:14 PM on October 21, 2019: member

ACK dedc8c7 (modulo Travis being able to download the SDK)

Re: WARNING: PROTOC not found: that means it's not finding protobuf in the depends. I'm also getting this issue on master, so indeed unrelated.

Without BIP70 I can build and do make deploy. Some light testing didn't reveal any issues.

fanquake commented at 6:06 PM on October 23, 2019: member

Me and Cory have been discussing moving straight to Clang 9, instead of 6. However that has turned up some issues related to Boost and Clangs -dumpversion. Cory is going to PR some changes first, then we can circle back around to here.

fanquake cross-referenced this on Oct 24, 2019 from issue depends: fix boost mac cross build with clang 9+ by theuni

fanquake force-pushed on Oct 25, 2019

fanquake commented at 7:49 PM on October 25, 2019: member

Pushed up a rebase here as reqeusted by theuni. Going to look at using the 10.15 SDK instead of the 10.14 SDK as well.

bitcoin deleted a comment on Nov 12, 2019

MarcoFalke commented at 6:46 PM on November 12, 2019: member

Pushed up a rebase here as reqeusted by theuni. Going to look at using the 10.15 SDK instead of the 10.14 SDK as well.

The 10.15 SDK gave problems, so sticking to 10.14 seems better for now? https://github.com/bitcoin-core/secp256k1/issues/674#issuecomment-546520166

MarcoFalke commented at 6:48 PM on November 12, 2019: member

Anything left to do here except pushing up the new SDK to our depends mirror?

fanquake commented at 7:26 PM on November 12, 2019: member

Anything left to do here except pushing up the new SDK to our depends mirror?

I have some cctools-port changes to review and we will likely switch to a newer version of Clang. I will get that done over the next 2 days.

fanquake added the label Waiting for author on Nov 12, 2019

fanquake cross-referenced this on Nov 14, 2019 from issue Feed environment data into RNG initializers by sipa

fanquake cross-referenced this on Nov 21, 2019 from issue build: set minimum supported macOS to 10.12 by fanquake

fanquake force-pushed on Nov 22, 2019

fanquake removed the label Waiting for author on Nov 22, 2019

fanquake commented at 2:11 PM on November 22, 2019: member

Sorry for the delay. I've pushed up the discussed changes. This is now based on top of #17550. I've also reordered the commits to have the SDK bump (10.14) at the end.

One thing left TODO is diff the the 10.14 & 10.15 headers. As well as the LLVM headers. Still going to do this even though we can't use the 10.15 SDK (Qt 5.9 or 5.12 wont build with it).

fanquake referenced this in commit a6f5b6f47d on Nov 22, 2019

fanquake force-pushed on Nov 22, 2019

MarcoFalke added the label Needs gitian build on Nov 22, 2019

MarcoFalke removed the label Needs gitian build on Nov 22, 2019

sidhujag referenced this in commit 016b46aabb on Nov 22, 2019

MarcoFalke added the label Needs gitian build on Nov 22, 2019

DrahtBot removed the label Needs gitian build on Nov 23, 2019

MarcoFalke added the label Needs gitian build on Dec 10, 2019

DrahtBot commented at 11:38 PM on December 11, 2019: contributor

Gitian builds

File	commit ea756bc48cd5eebc0e508fa7679e31f3e2848d60<br>(master)	commit 536e288d36fdb1a40f4d2273e2aaaf1bbd1f2ef7<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`1662f4bf8b0b3dfe...`	`cb5c472601bc9554...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`b2983be7590e2792...`	`5ba50117a3860d01...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`9d9e87021d691d46...`	`b58cf13c38bb53cd...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`0581a07f9df8a550...`	`0fffc3549db36d08...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`86e300a01dbd7e1c...`	`8ef92142945ba7a0...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`8c051782e303e06c...`	`6e1eded70e4ecd39...`
bitcoin-0.19.99-osx-unsigned.dmg	`56d99ada300198c4...`
bitcoin-0.19.99-osx64.tar.gz	`3f269ce1a8331c78...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`f97d7e4aec165ba8...`	`2936504d3c0f6a38...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`f71433d9c7c6bd0b...`	`5d28c62b42223ad9...`
bitcoin-0.19.99-win64-debug.zip	`055c6639876ec100...`	`cb4bb1b4e3277c50...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`f870106efaa940d6...`	`512c2aa9117d90c7...`
bitcoin-0.19.99-win64.zip	`3b2f5933bc66419f...`	`6770b22bfc91a5e2...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`6108e51e85b7c770...`	`ebda9dd2ad20a6f3...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`9c8a85c662ef09b6...`	`461734f3affa3117...`
bitcoin-0.19.99.tar.gz	`76f6b1a89ac8b42e...`	`d720f83ca5ac4922...`
bitcoin-core-linux-0.20-res.yml	`83207717cc17da3b...`	`ebcd4e6ddeb95e80...`
bitcoin-core-osx-0.20-res.yml	`06093d85ce7c8e0d...`
bitcoin-core-win-0.20-res.yml	`184c92964572e6e6...`	`8dd8c4b7ae001ff1...`
linux-build.log	`33f168241e23716f...`	`40fc4041c040c1ef...`
osx-build.log	`57e16d4d5596f266...`	`dad56d55090994f6...`
win-build.log	`23600f07b084cf93...`	`253cc07408f73213...`
bitcoin-core-linux-0.20-res.yml.diff		`d4e0af7826e13916...`
bitcoin-core-win-0.20-res.yml.diff		`59d36ac9e7a272a6...`
linux-build.log.diff		`37cfec29ca2022c6...`
osx-build.log.diff		`91d10f064efbca04...`
win-build.log.diff		`76d9a87e3c6543b2...`

DrahtBot removed the label Needs gitian build on Dec 11, 2019

bitcoin deleted a comment on Dec 12, 2019

fanquake cross-referenced this on Dec 18, 2019 from issue build: various build system improvements by fanquake

fanquake referenced this in commit 5270430be3 on Dec 18, 2019

fanquake added this to the "Blockers" column in a project

MarcoFalke commented at 9:35 PM on December 19, 2019: member

Idk why DrahtBot doesn't compile this. I am pretty sure I updated it to the newest sdk.

MarcoFalke added the label Needs gitian build on Dec 19, 2019

DrahtBot commented at 4:23 PM on December 20, 2019: contributor

Gitian builds

File	commit 6677be64f69b3d6f60f5a675ff9746def27a2de8<br>(master)	commit 4f09c775e80299f7b911b6a76b2c0bd518936c92<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`f92d4b448b73115a...`	`3e33be6a107ae08b...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`fd6bd132cb039dd8...`	`7d25fb166788e598...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`cb5587754977433e...`	`ca1132ac667c9e8a...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`e8a2f90d0634c4bc...`	`a7628ed31ffb8520...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`096c1e42406a8e71...`	`6955969eb02776b5...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`e3447695cdf64582...`	`72673bd65a3a3eef...`
bitcoin-0.19.99-osx-unsigned.dmg	`b869749e706814fc...`
bitcoin-0.19.99-osx64.tar.gz	`775cdf5feee01485...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`c7a8f7364455191f...`	`094ba25fd6f822ba...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`91302613a363f679...`	`3b7e2fe714272056...`
bitcoin-0.19.99-win64-debug.zip	`e9a65b6fa6cd380d...`	`0e62a1f080e1bac7...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`d7d3c504eb602e68...`	`4785616b468a1a81...`
bitcoin-0.19.99-win64.zip	`7f5a5b0268a69ba9...`	`743cebe3a17663ad...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`c36665ce75b7caf1...`	`20445ca1852fd977...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`ad3e8b465e0d33c9...`	`8e6f4f4b955ee3b5...`
bitcoin-0.19.99.tar.gz	`6c5e4f9857df5695...`	`3a0e753242185868...`
bitcoin-core-linux-0.20-res.yml	`ee712a1279b88c1d...`	`4da585eb7e305965...`
bitcoin-core-osx-0.20-res.yml	`77e14d27de62398f...`
bitcoin-core-win-0.20-res.yml	`6879406976cb49de...`	`d429f7f35b4ffdbb...`
linux-build.log	`4e7d1cd731586faa...`	`6201baa78d4d305d...`
osx-build.log	`fa909531180cdc48...`	`371c671510b3695d...`
win-build.log	`1974207ae76c1912...`	`e9d273fe4b2f04c3...`
bitcoin-core-linux-0.20-res.yml.diff		`a4c9e2184caa0bf7...`
bitcoin-core-win-0.20-res.yml.diff		`7e16036aabb632da...`
linux-build.log.diff		`61ded35a46c86799...`
osx-build.log.diff		`812725512d989996...`
win-build.log.diff		`c27d6f6327e7e051...`

DrahtBot removed the label Needs gitian build on Dec 20, 2019

fanquake force-pushed on Dec 21, 2019

fanquake cross-referenced this on Dec 24, 2019 from issue random: don't special case clock usage on macOS by fanquake

dongcarl cross-referenced this on Jan 13, 2020 from issue depends: Allow building with system clang by dongcarl

Empact commented at 9:32 PM on January 17, 2020: member

FYI the latest 10.11 security update from Apple was published in 09 Jul 2018. https://support.apple.com/en-us/HT201222

fanquake force-pushed on Jan 20, 2020

Sjors commented at 3:28 PM on January 31, 2020: member

tACK 248526e4f941edea8851a5a72a2a1da0ffdfabcf on macOS 10.15.3 (also tried make deploy), provided you can make Travis happy too. I'm not a build system connaisseur though, so an ACK from @theuni would be great.

We should drop the instructions for obtaining the 10.11 SDK, but that can wait for a followup.

fanquake cross-referenced this on Feb 3, 2020 from issue Bump macOS SDK version to 10.13 for gitian builds by hebasto

laanwj commented at 10:23 AM on February 3, 2020: member

FWIW https://bitcoincore.org/depends-sources/sdks/MacOSX10.14.sdk.tar.gz is up

depends: clang 6.0.1

This also removes some now-unnecessary cctools hacks.

Co-Authored-By: Cory Fields <cory-nospam-@coryfields.com>

1de8c067c7

depends: native_cctools 921, ld64 409.12, libtapi 1000.10.8

This also removes the obsolete mlinker-version option

Co-Authored-By: Cory Fields <cory-nospam-@coryfields.com>

ca5055a5aa

build: use macOS 10.14 SDK

Co-Authored-By: Carl Dong <accounts@carldong.me>

7e2104433c

fanquake force-pushed on Feb 3, 2020

fanquake added the label Needs gitian build on Feb 3, 2020

jonasschnelli commented at 3:19 PM on February 3, 2020: contributor

Tested ACK via a depends build with macOS SDK 10.14: https://bitcoinbuilds.org/?job=e969d43f-2cd8-4890-b5ae-bcc2d0ea4195

hebasto commented at 8:04 PM on February 3, 2020: member

FWIW https://bitcoincore.org/depends-sources/sdks/MacOSX10.14.sdk.tar.gz is up

Downloaded file

$ sha256sum MacOSX10.14.sdk.tar.gz 
2530c1d88f1aca98994cf32cfcf6099d880965ef0200b8b2a87279c191d56766  MacOSX10.14.sdk.tar.gz

seems broken.

UPDATE: it was a download error. This one

$ sha256sum MacOSX10.14.sdk.tar.gz 
328aff47e28c17093d59a72712a9b2e62cd8a8b87bbe03f91abb32960b413f0f  MacOSX10.14.sdk.tar.gz

is ok.

hebasto commented at 9:42 PM on February 3, 2020: member

Tested ca5055a5aa07aba81a87cf12f6f0526a63c423b5

Cross compilation on Linux Mint 19.3 with depends and MacOSX10.14.sdk was contaminated by system Qt packages (#18042, #18045, #18051):

$ make HOST=x86_64-apple-darwin16 -C depends
$ ./autogen.sh
$ CONFIG_SITE=$PWD/depends/x86_64-apple-darwin16/share/config.site ./configure
$ make
...
  CXX      qt/qt_libbitcoinqt_a-peertablemodel.o
qt/notificator.cpp:50:21: error: allocation of incomplete type 'QDBusInterface'
    interface = new QDBusInterface("org.freedesktop.Notifications",
                    ^~~~~~~~~~~~~~
...

The patch from #18051 was applied, then compilation passed successfully with loads of linker warnings like this:

  AR       qt/libbitcoinqt.a
  CXXLD    qt/bitcoin-qt
  CXXLD    qt/test/test_bitcoin-qt
ld: warning: direct access in function '__ZN5boost10filesystem6detail9canonicalERKNS0_4pathES4_PNS_6system10error_codeE' from file '/home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin16/lib/libboost_filesystem-mt-x64.a(operations.o)' to global weak symbol '__ZZN5boost6system16generic_categoryEvE25generic_category_instance' from file 'libbitcoin_server.a(libbitcoin_server_a-init.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
...

The resulted Bitcoin-Core.dmg was successfully installed on macOS 10.14 then launched .

DrahtBot commented at 7:02 AM on February 4, 2020: contributor

Gitian builds

File	commit 365c83e6a8399913cec5f0383978c28f8418fa3b<br>(master)	commit 27d2f29cdaf55523fec312e3d2e2bdaac03e7e97<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`970e730072cb3102...`	`8609bbf1aa2b58f9...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`935312465c6da174...`	`8388955a9e05dd7e...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`0ed6a37c55b14a2e...`	`20db37c7ce005f42...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`028f778eb4927763...`	`892195271fa0ef4f...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`1db644cdfe7214fb...`	`6b89a91ee86e506a...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`287253ed7574eaea...`	`c9fddc77aca47dc9...`
bitcoin-0.19.99-osx-unsigned.dmg	`821863528e68ec86...`
bitcoin-0.19.99-osx64.tar.gz	`1786b62a871209a2...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`22d076616e4c906e...`	`44e10a5b413dedab...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`c28b4fa1737df120...`	`2d2fa6cae56012cc...`
bitcoin-0.19.99-win64-debug.zip	`b9cae2f4ecb811b5...`	`6cf65d842ba0ecd0...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`33d162f55ec7a280...`	`8ae915b5ab910106...`
bitcoin-0.19.99-win64.zip	`2e9c7f3b6a81a019...`	`3fbd03c061614891...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`c6d3a034928bf42f...`	`65ac2d3021cc8432...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`3398c21d3cc2db4a...`	`13c74d3483fbe588...`
bitcoin-0.19.99.tar.gz	`53fdfce17dfd576e...`	`90861a5bf809f2cf...`
bitcoin-core-linux-0.20-res.yml	`5e3e3dc9d073bfe0...`	`38e155a1cb06ac2d...`
bitcoin-core-osx-0.20-res.yml	`bb414d323b8702a3...`
bitcoin-core-win-0.20-res.yml	`713d925b71fce216...`	`9e38b7994e600f6b...`
linux-build.log	`0fa8aec26c2484b6...`	`bf6f649b3431eb01...`
osx-build.log	`1e49555bff5faba3...`	`0a7dadee8b6a8695...`
win-build.log	`e61928f15b54a519...`	`baa346388eb2b994...`
bitcoin-core-linux-0.20-res.yml.diff		`99f87cfaad3ddb04...`
bitcoin-core-win-0.20-res.yml.diff		`621c33c6d581cc43...`
linux-build.log.diff		`6bbb682595787575...`
osx-build.log.diff		`ee4f9786dbeacc12...`
win-build.log.diff		`2680bcc8a823d25c...`

DrahtBot removed the label Needs gitian build on Feb 4, 2020

fanquake commented at 7:05 AM on February 4, 2020: member

@MarcoFalke Looks like DrahtBot is still missing the new SDK.

Sjors commented at 9:52 AM on February 4, 2020: member

re-ACK 7e2104433cd0905ccf94632511b3ca0ce5b0463b (rebased from 248526e)

dongcarl commented at 7:08 PM on February 4, 2020: contributor

@fanquake I apologize for my lateness, but here's my outstanding changes so that we can generate and use the SDK with headers as requested: https://github.com/fanquake/bitcoin/compare/macos-toolchain-update...dongcarl:2020-01-macos-sdk-with-headers

Here are the new instructions: https://github.com/dongcarl/bitcoin/blob/adf9968de5dc872e3c51e538f6b99e9423b65bd3/contrib/macdeploy/README.md#step-2-generating-macosx1014sdktargz-from-xcodeapp

laanwj commented at 10:43 AM on February 5, 2020: member

Let's try to get this merged soon—if we still want this for 0.20 it's not something that should be done last minute.

dongcarl commented at 11:32 AM on February 5, 2020: contributor

ACK 7e21044

Immediate followup: #18072

Empact commented at 11:35 AM on February 5, 2020: member

Built depends successfully on 10.14.6

Is there anything more to say re the "obsolete mlinker-version option"? Is it obsolete only in that it is no longer required for build?

dongcarl cross-referenced this on Feb 5, 2020 from issue Use `libc++` headers from macOS SDK instead of from clang by dongcarl

laanwj referenced this in commit c8ce2632eb on Feb 5, 2020

laanwj merged this on Feb 5, 2020

laanwj closed this on Feb 5, 2020

laanwj commented at 1:30 PM on February 5, 2020: member

@fanquake I apologize for my lateness, but here's my outstanding changes so that we can generate and use the SDK with headers as requested: fanquake/bitcoin@macos-toolchain-update...dongcarl:2020-01-macos-sdk-with-headers

Thanks, please add these instructions in a new PR!

dongcarl commented at 4:35 PM on February 5, 2020: contributor

@fanquake I apologize for my lateness, but here's my outstanding changes so that we can generate and use the SDK with headers as requested: fanquake/bitcoin@macos-toolchain-update...dongcarl:2020-01-macos-sdk-with-headers

Thanks, please add these instructions in a new PR!

It's here! :-) #18072

fanquake deleted the branch on Feb 6, 2020

fanquake removed this from the "Blockers" column in a project

MarcoFalke cross-referenced this on Feb 11, 2020 from issue jonatack 0.19.1rc2 unsigned sigs by jonatack

laanwj referenced this in commit 1a51cd1ac5 on Feb 28, 2020

sidhujag referenced this in commit 639537df89 on Feb 29, 2020

deadalnix referenced this in commit 32440df7de on Mar 26, 2020

deadalnix referenced this in commit 1b6adb5086 on Mar 27, 2020

MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ

ftrader referenced this in commit 4e61af73d7 on May 19, 2020

str4d cross-referenced this on Jul 30, 2020 from issue Modernise macOS cross-compilation toolchain by str4d

zkbot referenced this in commit 2a39656e6d on Jul 30, 2020

zkbot referenced this in commit e0692ed4df on Aug 7, 2020

sidhujag referenced this in commit e6a74d1ea3 on Nov 10, 2020

sidhujag referenced this in commit 45b75873ec on Nov 10, 2020

hebasto cross-referenced this on Dec 21, 2020 from issue script: Remove outdated extract-osx-sdk.sh by hebasto

laanwj referenced this in commit f4ac48d30a on Dec 21, 2020

sidhujag referenced this in commit 0a4a17691d on Dec 21, 2020

Fuzzbawls cross-referenced this on Mar 26, 2021 from issue [Depends] Update macOS cross-compiling toolchain by Fuzzbawls

furszy referenced this in commit 816f42d7ac on May 25, 2021

kwvg referenced this in commit 428aff35e2 on Jul 15, 2021

kwvg referenced this in commit 2dec821b43 on Jul 15, 2021

kwvg referenced this in commit 3da3f41386 on Jul 20, 2021

kwvg referenced this in commit 9e7883cf19 on Jul 20, 2021

kwvg referenced this in commit 37e36d51e8 on Jul 20, 2021

kwvg referenced this in commit a3156df2f5 on Jul 20, 2021

kwvg referenced this in commit 6541754a8a on Aug 1, 2021

kwvg referenced this in commit 8d60a361bb on Aug 24, 2021

kwvg referenced this in commit 18da0abdd0 on Aug 24, 2021

kwvg referenced this in commit ff51a02983 on Aug 25, 2021

kwvg referenced this in commit f3a0d37065 on Aug 25, 2021

kwvg referenced this in commit 86ef0f7bc9 on Aug 26, 2021

kwvg referenced this in commit 1e38f00776 on Aug 26, 2021

kwvg referenced this in commit e11d087f8d on Aug 26, 2021

kwvg referenced this in commit 708cc7575d on Aug 27, 2021

kwvg referenced this in commit 0bb694d91a on Aug 30, 2021

kwvg referenced this in commit abaa0b3c92 on Sep 1, 2021

kwvg referenced this in commit a358d2e593 on Sep 1, 2021

lyricidal cross-referenced this on Oct 31, 2021 from issue [Upstream] [Depends] Update macOS cross-compiling toolchain by lyricidal

bitcoin locked this on Feb 15, 2022