build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) #16344

1. 
   Sjors commented at 4:39 PM on July 5, 2019: member

   It seems that AC_DEFINE([HAVE_SYSTEM], [HAVE_STD__SYSTEM || HAVE_WSYSTEM] causes HAVE_SYSTEM to always be defined, so we need to use #if HAVE_SYSTEM instead of #if defined(HAVE_SYSTEM).

   Followup for #15457, can be tested with #12557.

2. [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) 976b034b13
3. Sjors cross-referenced this on Jul 5, 2019 from issue Check std::system for -[alert|block|wallet]notify by Sjors
4. fanquake added the label Build system on Jul 5, 2019
5. 
   qmma70 commented at 12:13 AM on July 6, 2019: contributor

   Approach ACK. AC_DEFINE will always define the pre-processor symbol.

6. fanquake requested review from dongcarl on Jul 6, 2019
7. 
   promag commented at 2:57 PM on July 6, 2019: member

   ACK 976b034b13d28877aee641833d5ee28a8cc5d83f.

8. 
   dongcarl commented at 5:08 PM on July 6, 2019: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/16344/commits/976b034b13d28877aee641833d5ee28a8cc5d83f.

   Perhaps (in another PR/issue) we should make sure that for other preprocessor symbols we mean define(FOOBAR) when we say it. @fanquake does that sound reasonable?

9. fanquake renamed this:
   [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
   build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
   on Jul 7, 2019
10. fanquake approved
11. 
    fanquake commented at 2:36 AM on July 7, 2019: member

    ACK 976b034b13d28877aee641833d5ee28a8cc5d83f

    Tested on my macOS system with master (584168c7f9d9e78a3bf82ab85b52feb0ced67f9d) and with #12557.

    Perhaps (in another PR/issue) we should make sure that for other preprocessor symbols we mean define(FOOBAR) when we say it. @fanquake does that sound reasonable? @dongcarl yes that sounds like a good idea.

12. fanquake merged this on Jul 7, 2019
13. fanquake closed this on Jul 7, 2019

    ---

14. fanquake referenced this in commit f373beebbc on Jul 7, 2019
15. Sjors deleted the branch on Jul 7, 2019
16. dongcarl cross-referenced this on Jul 18, 2019 from issue Check usages of `#if defined(...)` by dongcarl
17. PastaPastaPasta referenced this in commit 79e5eb8a63 on Oct 22, 2021
18. bitcoin locked this on Dec 16, 2021

Contributors

Sjorsqmma70promagdongcarlfanquake

Review Requested
dongcarl