refactor: Avoid UniValue copy constructor #15974

pull promag wants to merge 1 commits into bitcoin:master from promag:2019-05-copy-univalue changing 8 files +22 −24
  1. promag commented at 3:18 PM on May 7, 2019: member

    Remove unnecessary UniValue copies. Not sure if this change is exhaustive without changing UniValue or if there is a way to detect that.

    A followup is to add move semantics to UniValue and remove some unnecessary members of UniValue.

    This work is related to #15925.

  2. refactor: Avoid UniValue copy constructor 879ce09cab
  3. jgarzik commented at 3:22 PM on May 7, 2019: contributor

    UniValue constructor improvements welcomed... a version 2.0 that ditches old APIs (no impact on bitcoin) is scheduled, fwiw.

  4. promag cross-referenced this on May 7, 2019 from issue univalue: Drop overloaded members by promag
  5. practicalswift commented at 3:46 PM on May 7, 2019: contributor

    Concept ACK

  6. DrahtBot added the label Refactoring on May 7, 2019
  7. DrahtBot added the label RPC/REST/ZMQ on May 7, 2019
  8. DrahtBot added the label Wallet on May 7, 2019
  9. Empact commented at 9:00 PM on May 7, 2019: member

    Concept ACK - some NullUniValue changes could be scripted to be verifiably consistent and comprehensive

  10. DrahtBot commented at 7:22 PM on June 19, 2019: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16251 (Improve signrawtransaction error reporting by ajtowns)
    • #16240 (JSONRPCRequest-aware RPCHelpMan by kallewoof)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  11. fanatid cross-referenced this on Jun 22, 2019 from issue bench: Benchmark blockToJSON by fanatid
  12. laanwj referenced this in commit 0a6ee9797e on Jul 8, 2019
  13. sidhujag referenced this in commit 6678aba111 on Jul 9, 2019
  14. DrahtBot commented at 11:41 PM on July 9, 2019: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase

  15. DrahtBot added the label Needs rebase on Jul 9, 2019
  16. promag closed this on Jul 28, 2019
  17. promag deleted the branch on Jul 28, 2019
  18. laanwj removed the label Needs rebase on Oct 24, 2019
  19. Munkybooty referenced this in commit 2cd358cfcb on Nov 4, 2021
  20. Munkybooty referenced this in commit da34449bb7 on Nov 4, 2021
  21. bitcoin locked this on Dec 16, 2021
Contributors
promagjgarzikpracticalswiftEmpactDrahtBot
Labels
RefactoringWalletRPC/REST/ZMQ
Linked (view graph)
#15925 getblock performance issue on verbosity#15975 univalue: Drop overloaded members#16267 bench: Benchmark blockToJSON#25429 refactor: Avoid UniValue copies
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC