Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options #15913

1. 
   luke-jr commented at 4:46 AM on April 28, 2019: member

   When building w/o wallet support, we add all the wallet options as hidden options to avoid throwing errors/warnings that they're unknown.

   -ignorepartialspends is missing from this list. This PR adds it.

   (This seems like a good candidate for a linter? Or maybe we can autogenerate it?)

   Also reformats the dummywallet options list across multiple lines to make conflicts less often.

2. dummywallet: Reformat ignored wallet options list 0f09eb779d
3. Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options 765d5890be
4. fanquake added the label Wallet on Apr 28, 2019
5. 
   DrahtBot commented at 5:43 AM on April 28, 2019: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15876 ([rpc] signer bump fee by Sjors)
   • #14912 ([WIP] External signer support (e.g. hardware wallet) by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   meshcollider commented at 10:13 AM on April 28, 2019: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/15913/commits/765d5890be46ed5f5557c1d2b3cb931e6b8eb3b0

7. 
   MarcoFalke commented at 2:31 PM on April 28, 2019: member

   utACK 765d5890be46ed5f5557c1d2b3cb931e6b8eb3b0

   <details><summary>Show signature</summary>

   -----BEGIN PGP SIGNED MESSAGE-----
   Hash: SHA512
   
   utACK 765d5890be46ed5f5557c1d2b3cb931e6b8eb3b0
   -----BEGIN PGP SIGNATURE-----
   
   iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
   pUhXNQv/bJNXsHQ/cB73ZsX3PmHL7vNjhGZkTWu0t5RRG6jKB6QxgWE4y2Mf3m9w
   GFURtVz9pop6+Rsl+MgT2FwvXtvgnFp/2jthN3lXNU7u22BB8uVPAS7CUUXKqEH9
   zo5Xp9Q/8GCh0z/GSHJyxVa0GT7DdYs9GfXWakKStbQ+PO42ZJI2eT8V+AMiFP2s
   kiyJHX55I1xCqwwRNQn3Alrsq+cvsXWfSb9QutsinJLDCzeVa7K342CY+YKxVKU6
   TqyDig/Ex3rdW0+1LqdPgKX8xugEEahfRAS9pI3g3YPgh7coJb2vCBRlRi5dpN9h
   WBrs0ZxUlmcp8yncPqOilJCGP4mpRUTAtxEcbmfjgEE67qpl+4DflLTH8NQyaJT6
   cj/eISi1tRUimPApgbkcfNn41JK+lR6oen1Xa1MXZnwWQXb3Au4cEiE2gyyC1cTX
   UD2Q04K2qES1dm1Jxu8lIVWhQkOorNInBo6H0Siaphzcm5adzbW5fBRai4eQWRAe
   oh7e2uMF
   =QgEK
   -----END PGP SIGNATURE-----
   

   </details> [@luke-jr](/github-metadata-backup-bitcoin-bitcoin/contributor/luke-jr/) See https://github.com/MarcoFalke/bitcoin/commit/fac174e2d17e06b63aa5eb20b404af00d38db26e for a linter fixup

8. 
   promag commented at 10:40 PM on April 28, 2019: member

   utACK 765d589.

9. 
   practicalswift commented at 7:02 AM on April 29, 2019: contributor

   utACK 765d5890be46ed5f5557c1d2b3cb931e6b8eb3b0

   Good idea with a linter guarding against this happening in the future.

10. 
    fanquake commented at 12:35 PM on April 29, 2019: member

    utACK 765d589

11. MarcoFalke merged this on Apr 29, 2019
12. MarcoFalke closed this on Apr 29, 2019

    ---

13. MarcoFalke referenced this in commit c1d2b76d80 on Apr 29, 2019
14. 
    luke-jr commented at 6:41 AM on May 1, 2019: member

    Probably should tag this for backport to 0.18.1

15. fanquake added the label Needs backport on May 1, 2019
16. fanquake added this to the milestone 0.18.1 on May 1, 2019
17. 
    Sjors commented at 2:24 PM on May 12, 2019: member

    Also reformats the dummywallet options list across multiple lines to make conflicts less often.

    Thanks, that was indeed leading to frequent rebase needs for me in #14145.

    Post merge utACK

18. MarcoFalke referenced this in commit 106471d0d7 on Jun 11, 2019
19. MarcoFalke cross-referenced this on Jun 11, 2019 from issue 0.18: Backport "Add -ignorepartialspends to list of ignored wallet options" by MarcoFalke
20. MarcoFalke removed the label Needs backport on Jun 11, 2019
21. 
    Empact commented at 9:43 PM on June 11, 2019: member

    For the record, this adds -avoidpartialspends to the ignored list.

22. laanwj referenced this in commit 9c29bc71dc on Jun 13, 2019
23. uhliksk referenced this in commit 7fbc77118e on Jun 27, 2019
24. uhliksk referenced this in commit ac8f2d7eba on Jun 27, 2019
25. uhliksk referenced this in commit d56fb3d877 on Jun 27, 2019
26. uhliksk referenced this in commit 7b713f6acf on Jun 28, 2019
27. uhliksk referenced this in commit 21d7a2aa63 on Jun 28, 2019
28. fxtc referenced this in commit 4b4cc0bbfc on Aug 6, 2019
29. uhliksk referenced this in commit fe5615ca1d on Aug 6, 2019
30. HashUnlimited referenced this in commit b86ced047a on Aug 23, 2019
31. Bushstar referenced this in commit f8cdf5d0d7 on Aug 24, 2019
32. Bushstar referenced this in commit e669ecc6a3 on Aug 24, 2019
33. Bushstar referenced this in commit 10d7f3335f on Aug 24, 2019
34. Bushstar referenced this in commit 9211f185b2 on Aug 24, 2019
35. vijaydasmp referenced this in commit 6a8986c778 on Sep 13, 2021
36. PastaPastaPasta referenced this in commit e853e7e95a on Sep 18, 2021
37. PastaPastaPasta referenced this in commit 96ebf40b24 on Sep 28, 2021
38. kwvg referenced this in commit f0d143e029 on Oct 12, 2021
39. bitcoin locked this on Feb 15, 2022

Contributors

luke-jrDrahtBotmeshcolliderMarcoFalkepromagpracticalswiftfanquakeSjorsEmpact

Milestone
0.18.1