Avoid redefine warning #15782

pull Bushstar wants to merge 1 commits into bitcoin:master from Bushstar:warning-redefine changing 1 files +2 −0

Bushstar commented at 11:27 AM on April 10, 2019: contributor

Wrap preprocessor definition of NOMINMAX in ifndef conditional to suppress warning when cross compiling Windows.

fs.cpp:6:0: warning: "NOMINMAX" redefined /usr/lib/gcc/x86_64-w64-mingw32/7.3-posix/include/c++/x86_64-w64-mingw32/bits/os_defines.h:45:0: note: this is the location of the previous definition #define NOMINMAX 1

#define NOMINMAX was introduced in the following merge.

https://github.com/bitcoin/bitcoin/pull/14426
Avoid redefine warning 0b3a65455a
fanquake added the label Refactoring on Apr 10, 2019
practicalswift commented at 11:33 AM on April 10, 2019: contributor

utACK 0b3a65455a20504a66355ae2e6f0a83cb8462f3c
promag commented at 12:40 PM on April 10, 2019: member

utACK 0b3a654.
laanwj merged this on Apr 11, 2019
laanwj closed this on Apr 11, 2019
laanwj referenced this in commit 570eb7b130 on Apr 11, 2019
jasonbcox referenced this in commit e396302584 on Oct 5, 2020
PastaPastaPasta referenced this in commit ffba4141b7 on Jun 27, 2021
PastaPastaPasta referenced this in commit dcf92c1d20 on Jun 28, 2021
PastaPastaPasta referenced this in commit 92740dcd5f on Jun 29, 2021
PastaPastaPasta referenced this in commit 4670959d4a on Jul 1, 2021
PastaPastaPasta referenced this in commit 1b92905cdc on Jul 1, 2021
Fuzzbawls cross-referenced this on Aug 8, 2021 from issue [Bug] Fix improper locking on Windows WSL1 environments by Fuzzbawls
random-zebra referenced this in commit c2b36fe7a2 on Aug 9, 2021
PastaPastaPasta referenced this in commit bb0c4dbb23 on Sep 28, 2021
kwvg referenced this in commit 79cbf5bbf3 on Oct 12, 2021
str4d cross-referenced this on Dec 6, 2021 from issue Backport changes to `src/fs.{cpp,h}` by str4d
bitcoin locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#14426 utils: Fix broken Windows filelock