test: Add wallet_balance benchmark #15779

  13 | +struct WalletTestingSetup {
  14 | +    std::unique_ptr<interfaces::Chain> m_chain = interfaces::MakeChain();
  15 | +    CWallet m_wallet;
  16 | +
  17 | +    WalletTestingSetup()
  18 | +        : m_wallet{m_chain.get(), WalletLocation(), WalletDatabase::CreateMock()}

ryanofsky commented at 4:18 PM on April 17, 2019:

Could get rid of WalletTestingSetup constructor and just initialize m_wallet directly above.

  30 | +    const auto& ADDRESS_WATCHONLY = ADDRESS_BCRT1_UNSPENDABLE;
  31 | +
  32 | +    WalletTestingSetup wallet_t{};
  33 | +    auto& wallet = wallet_t.m_wallet;
  34 | +    {
  35 | +        bool first_run;

ryanofsky commented at 4:21 PM on April 17, 2019:

I think there's no need for this to be indented, but I guess it's reasonable to limit the scope the first_run variable.

   8 | +#include <optional.h>
   9 | +#include <test/util.h>
  10 | +#include <validationinterface.h>
  11 | +#include <wallet/wallet.h>
  12 | +
  13 | +struct WalletTestingSetup {

ryanofsky commented at 4:32 PM on April 17, 2019:

This seems fine, but in the future it might be better not have two different structs called WalletTestingSetup with different implementations. (The other one is https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/wallet_test_fixture.h), because if the other WalletTestingSetup struct is ever used in a benchmark, it might result in weird link errors or even runtime errors.

I think if you just took the handleNotifications method below and moved it to the CWallet class as a public method, this struct would be simpler and no longer need to be declared a CWallet friend, and it could move to a private namespace to avoid conflicting with the other struct.

  21 | @@ -22,6 +22,8 @@
  22 |  
  23 |  #include <boost/thread.hpp>
  24 |  
  25 | +const std::string ADDRESS_BCRT1_UNSPENDABLE = "bcrt1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq3xueyj";

decryp2kanon commented at 1:09 PM on October 23, 2020:

interesting. just curious, how to create this un-spendable address? @MarcoFalke