rpc: getrpcinfo docs #15754

1. 
   benthecarman commented at 5:52 AM on April 5, 2019: contributor

   Fixes #15731

2. fanquake added the label Docs on Apr 5, 2019
3. fanquake added the label RPC/REST/ZMQ on Apr 5, 2019
4. in src/rpc/server.cpp:302 in 54f7fdf7cb outdated

    296 | @@ -297,8 +297,17 @@ static UniValue getrpcinfo(const JSONRPCRequest& request)
    297 |              RPCHelpMan{"getrpcinfo",
    298 |                  "\nReturns details of the RPC server.\n",
    299 |                  {},
    300 | -                RPCResults{},
    301 | -                RPCExamples{""},
    302 | +                RPCResult{
    303 | +            "{ (json object with active commands)\n"
    304 | +            "  { (json object with information about an active command)\n"
   

   ---

   ---

   

   promag commented at 6:32 AM on April 5, 2019:

   Should have the key "active_commands": saying it's a json array.

   ---

   

   benthecarman commented at 6:38 AM on April 5, 2019:

   fixed

5. benthecarman force-pushed on Apr 5, 2019
6. 
   promag commented at 6:53 AM on April 5, 2019: member

   The output should be something like

   Result:
   {
    "active_commands" (array) All active commands
      [                 
        {             (object) Information about an active command
          "method"    (string) The name of the RPC command
          "duration"  (numeric) The running time in microseconds
        },...
      ]
   }
   

7. rpc: getrpcinfo docs f4b7a2f205
8. benthecarman force-pushed on Apr 5, 2019
9. 
   promag commented at 3:23 PM on April 5, 2019: member

   LGTM.

10. MarcoFalke added this to the milestone 0.18.0 on Apr 8, 2019
11. MarcoFalke added the label Needs backport on Apr 8, 2019
12. MarcoFalke removed the label Needs backport on Apr 8, 2019
13. MarcoFalke removed this from the milestone 0.18.0 on Apr 8, 2019
14. MarcoFalke added this to the milestone 0.18.1 on Apr 8, 2019
15. MarcoFalke added the label Needs backport on Apr 8, 2019
16. promag cross-referenced this on Apr 8, 2019 from issue v0.18.0 testing by Sjors
17. in src/rpc/server.cpp:301 in f4b7a2f205

     296 | @@ -297,8 +297,20 @@ static UniValue getrpcinfo(const JSONRPCRequest& request)
     297 |              RPCHelpMan{"getrpcinfo",
     298 |                  "\nReturns details of the RPC server.\n",
     299 |                  {},
     300 | -                RPCResults{},
     301 | -                RPCExamples{""},
     302 | +                RPCResult{
     303 | +            "{\n"
    

    ---

    ---

    

    laanwj commented at 9:01 AM on April 10, 2019:

    Maybe indent this line and the strings below it four to the right?

18. 
    laanwj commented at 9:01 AM on April 10, 2019: member

    utACK f4b7a2f2055fa52d5e02c37bed7b46599b960e2e

19. MarcoFalke removed this from the milestone 0.18.1 on Apr 10, 2019
20. MarcoFalke added this to the milestone 0.18.0 on Apr 10, 2019
21. MarcoFalke merged this on Apr 10, 2019
22. MarcoFalke closed this on Apr 10, 2019

    ---

23. MarcoFalke referenced this in commit e82f6ad6f2 on Apr 10, 2019
24. benthecarman referenced this in commit 60d4621975 on Apr 11, 2019
25. benthecarman cross-referenced this on Apr 11, 2019 from issue [0.18] backport #15754 by benthecarman
26. laanwj referenced this in commit f42ed1442e on Apr 15, 2019
27. 
    fanquake commented at 12:44 PM on April 15, 2019: member

    Bckported in #15790.

28. fanquake removed the label Needs backport on Apr 15, 2019
29. benthecarman deleted the branch on Apr 16, 2019
30. HashUnlimited referenced this in commit 0c6e9e634b on Apr 19, 2019
31. jasonbcox referenced this in commit 6e2b7528f8 on Oct 5, 2020
32. bitcoin locked this on Dec 16, 2021

Contributors

benthecarmanpromaglaanwjfanquake

Milestone
0.18.0