GUI: optionsmodel cleanup #1572

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:optionsmodel_cleanup changing 2 files +36 −58

Diapolo commented at 11:46 AM on July 9, 2012: none
- cleanup optionsmodel before adding new proxy options
- place SOCKS version stuff below proxy port (IP, Port, SOCKS version)
- simplyfy some parts of the code (e.g. don't check IP and port, as this is done in optionsdialog anyway, remove unneeded {} in switch/case)
- small comsetic changed in the header for better readability
This is what I intend to do with the proxy options (not included here):
laanwj commented at 12:37 PM on July 10, 2012: member

ACK

optionsmodel cleanup

- cleanup optionsmodel before adding new proxy options
- place SOCKS version stuff below proxy port (IP, Port, SOCKS version)
- simplyfy some parts of the code (e.g. don't check IP and port, as this
  is done in optionsdialog anyway, remove unneeded {} in switch/case)
- small cosmetic changes in the header for better readability

144bfd9c53

Diapolo cross-referenced this on Jul 12, 2012 from issue add a LOCK in optionsmodel to ApplyProxySettings() by Diapolo
Diapolo commented at 1:44 PM on July 12, 2012: none

Rebased without further code changes, because I based #1589 on this!
laanwj referenced this in commit 4a7d53ee23 on Jul 12, 2012
laanwj merged this on Jul 12, 2012
laanwj closed this on Jul 12, 2012
nifgraup referenced this in commit f124acc22d on Mar 30, 2014
suprnurd referenced this in commit 8b5f47e686 on Dec 5, 2017
bitcoin locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

Linked (view graph)

#1589 add a LOCK in optionsmodel to ApplyProxySettings()