depends: Make less assumptions about build env #15581

pull dongcarl wants to merge 3 commits into bitcoin:master from dongcarl:2019-03-true-neutral-depends changing 4 files +11 −10
  1. dongcarl commented at 6:02 PM on March 11, 2019: contributor

    Removes some implicit assumptions that the depends system has about its environment and, as a side-effect, makes it possible to build the depends tree under severely privilege-limited environments such as containers built by Guix.

  2. dongcarl added the label Build system on Mar 11, 2019
  3. dongcarl added the label Needs gitian build on Mar 11, 2019
  4. DrahtBot commented at 9:57 PM on March 11, 2019: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14137 (gui: Add Windows taskbar progress by ken2812221)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. fanquake commented at 2:21 AM on March 12, 2019: member

    Concept ACK

  6. MarcoFalke commented at 3:49 PM on March 12, 2019: member

    utACK d46af06eae0cac3202d013e196045cce30b0ec77

  7. in depends/funcs.mk:78 in bef1df5230 outdated 
      76 | @@ -77,7 +77,7 @@ $(1)_download_path_fixed=$(subst :,\:,$$($(1)_download_path))
  77 |  
  78 |  #default commands
    ryanofsky commented at 7:25 PM on March 12, 2019:

    In commit "depends: tar: Always extract as yourself" (bef1df52301e57ba53ed38cbc038529f76c7ee5b)

    Could mention purpose of --no-same-owner in a comment here (tar will try to set ownership when running as uid 0 and may not succeed), since it's not so obvious

  8. ryanofsky approved
  9. ryanofsky commented at 7:33 PM on March 12, 2019: contributor

    utACK d46af06eae0cac3202d013e196045cce30b0ec77

  10. fanquake cross-referenced this on Mar 13, 2019 from issue contrib: Enable building in Guix containers by dongcarl
  11. ryanofsky approved
  12. ryanofsky commented at 3:26 PM on March 13, 2019: contributor

    utACK d93414c8ba81adb15f43023402be5941ea4960d0, only change since last review is adding comment

  13. DrahtBot commented at 1:56 PM on March 14, 2019: contributor

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit c3b1cb958f7c57c5d87db663f2b1a83e3471d354 (master):

    Gitian builds for commit 73322baa5872de7c835727c65b143fc765f5cb26 (master and this pull):

  14. DrahtBot removed the label Needs gitian build on Mar 14, 2019
  15. fanquake commented at 6:15 AM on March 15, 2019: member

    utACK https://github.com/bitcoin/bitcoin/pull/15581/commits/d93414c8ba81adb15f43023402be5941ea4960d0 after squashing the fixup!.

    Ran a depends build and compiled Core on macOS.

    tar -no-same-owner / -o:

    When extracting an archive, do not attempt to preserve the owner specified in the tar archive. This the default behavior for ordinary users.

  16. dongcarl force-pushed on Mar 18, 2019
  17. depends: Defer to Python detected by autoconf
    Since autoconf already detects the correct python binary path, we should
use that instead of going around it. Also has the benefit of working in
extremely restricted environments where /usr/bin/env might not be
available.
    340ef50772
  18. depends: tar: Always extract as yourself
    For normal users, --no-same-owner is default, but not so for root, where
it is assumed that root can change ownership willy-nilly. This is not
the case for privilege-limited container environments where we gaslight
the process into thinking it's root.
    89bee1bdbf
  19. depends: qt: Don't hardcode pwd path
    Let a man use his builtins if he wants to! Also, removes the unnecessary
assumption that pwd lives under /bin/pwd.
    f7696e6183
  20. dongcarl commented at 3:05 PM on March 18, 2019: contributor

    Squashed.

  21. MarcoFalke commented at 3:29 PM on March 18, 2019: member

    re-utACK f7696e6183ec58b5362ccc05e7c4e923caa77230 (only change is rebase and adding the comment)

  22. MarcoFalke merged this on Mar 18, 2019
  23. MarcoFalke closed this on Mar 18, 2019
  24. MarcoFalke referenced this in commit 2c336a9ccd on Mar 18, 2019
  25. str4d cross-referenced this on Oct 6, 2019 from issue Enable macOS cross-compilation by str4d
  26. zkbot referenced this in commit a96942e809 on Dec 11, 2019
  27. deadalnix referenced this in commit ee1c4e3d09 on Mar 31, 2020
  28. ftrader referenced this in commit 1df4359146 on Aug 17, 2020
  29. PastaPastaPasta referenced this in commit 069df0cbfe on Jun 27, 2021
  30. PastaPastaPasta referenced this in commit 87587f27d2 on Jun 28, 2021
  31. PastaPastaPasta referenced this in commit 83bda0e314 on Jun 29, 2021
  32. PastaPastaPasta referenced this in commit 6cd4c3aca2 on Jul 1, 2021
  33. PastaPastaPasta referenced this in commit 8fe843f391 on Jul 1, 2021
  34. PastaPastaPasta referenced this in commit b73836f454 on Jul 8, 2021
  35. PastaPastaPasta referenced this in commit 4a543ac7ea on Jul 10, 2021
  36. bitcoin locked this on Dec 16, 2021
Contributors
dongcarlDrahtBotfanquakeMarcoFalkeryanofsky
Labels
Build system
Linked (view graph)
#15277 contrib: Enable building in Guix containers
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC