build: use full version string in setup.exe #15548

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1903-winVer changing 1 files +5 −6
  1. MarcoFalke commented at 5:22 PM on March 6, 2019: member

    Fixes: #15546

  2. MarcoFalke added the label Windows on Mar 6, 2019
  3. MarcoFalke added the label Build system on Mar 6, 2019
  4. MarcoFalke added the label Needs gitian build on Mar 6, 2019
  5. laanwj commented at 10:31 AM on March 7, 2019: member

    Concept ACK. this would leave one file to be manually renamed before uploading the binaries

    mv ${SOURCEDIR}/bitcoin-osx-signed.dmg ${DESTDIR}/bitcoin-${VERSIONTO}-osx.dmg
  6. laanwj commented at 11:54 AM on March 7, 2019: member

    One concern: how does this interact with the gitian-win-signer.yml? My memory isn't entirely clear on how it works, but would it need to be modified to expect the new name?

  7. MarcoFalke commented at 3:12 PM on March 7, 2019: member

    I think it signs anything that ends with *-unsigned.exe

  8. DrahtBot removed the label Needs gitian build on Mar 7, 2019
  9. build: use full version string in setup.exe fa55104cb8
  10. MarcoFalke force-pushed on Mar 7, 2019
  11. MarcoFalke added the label Needs gitian build on Mar 7, 2019
  12. bitcoin deleted a comment on Mar 7, 2019
  13. laanwj added this to the milestone 0.18.0 on Mar 8, 2019
  14. MarcoFalke added the label Needs backport on Mar 8, 2019
  15. DrahtBot commented at 8:26 AM on March 9, 2019: contributor

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit d211edb34982aedbcd514ba3723396f2369ff286 (master):

    Gitian builds for commit ccc2958ac8ebd3a706590dc6b96770abf4485b6b (master and this pull):

  16. DrahtBot removed the label Needs gitian build on Mar 9, 2019
  17. in share/setup.nsi.in:61 in fa55104cb8 
      57 | @@ -59,12 +58,12 @@ CRCCheck on
  58 |  XPStyle on
  59 |  BrandingText " "
  60 |  ShowInstDetails show
  61 | -VIProductVersion ${VERSION}.@CLIENT_VERSION_BUILD@
  62 | +VIProductVersion @CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@
    promag commented at 12:34 PM on March 11, 2019:

    There are other places where this is done, like https://github.com/bitcoin/bitcoin/blob/257f750cd986641afe04316ed0b22b646b56b60b/src/bitcoin-cli-res.rc#L5

    Makes sense to define this in configure.ac (other PR)?

    MarcoFalke commented at 2:23 PM on March 11, 2019:

    Yeah, other PR. The goal of this one is really only to change the OutFile

  18. promag commented at 12:35 PM on March 11, 2019: member

    utACK fa55104cb8e73c709e90fc5f81c9cb6a8a0713a6.

    I agree it is better to use PACKAGE_VERSION and remove define VERSION ...

  19. laanwj referenced this in commit 021a9ad6f1 on Mar 12, 2019
  20. laanwj merged this on Mar 12, 2019
  21. laanwj closed this on Mar 12, 2019
  22. laanwj referenced this in commit e5770677de on Mar 12, 2019
  23. HashUnlimited referenced this in commit 1ee3abdf71 on Mar 12, 2019
  24. HashUnlimited cross-referenced this on Mar 12, 2019 from issue build: use full version string in setup.exe by HashUnlimited
  25. MarcoFalke deleted the branch on Mar 12, 2019
  26. MarcoFalke removed the label Needs backport on Mar 12, 2019
  27. PrinceKK300188-zz cross-referenced this on Oct 16, 2019 from issue build: use full version string in setup by PrinceKK300188-zz
  28. Fuzzbawls cross-referenced this on Nov 25, 2019 from issue [Build] Include full version in release file names by Fuzzbawls
  29. random-zebra referenced this in commit 0f92bf8e17 on Nov 25, 2019
  30. lyricidal cross-referenced this on Nov 26, 2019 from issue DAPS-1248 From PIVX: [Build] Include full version in release file names by lyricidal
  31. PastaPastaPasta referenced this in commit 9b68cccbda on Jun 27, 2021
  32. PastaPastaPasta referenced this in commit ec0bdead60 on Jun 28, 2021
  33. PastaPastaPasta referenced this in commit e7b68a35b0 on Jun 29, 2021
  34. PastaPastaPasta referenced this in commit 6cbef2734c on Jul 1, 2021
  35. PastaPastaPasta referenced this in commit c1b3411215 on Jul 1, 2021
  36. PastaPastaPasta referenced this in commit 4ee84598df on Jul 8, 2021
  37. PastaPastaPasta referenced this in commit 55880fbe08 on Jul 10, 2021
  38. bitcoin locked this on Dec 16, 2021
Contributors
MarcoFalkelaanwjDrahtBotpromag
Labels
WindowsBuild system

Milestone
0.18.0

Linked (view graph)
#15546 gitian: Windows installer EXE filenames lack "rcN" suffix#17168 build: use full version string in setup
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC