MarcoFalke
commented at 7:55 PM on February 28, 2019:
member
Link against BasicTestingSetup in the fuzz tests, so we can fuzz against validation.
Also include a commit to remove test_bitcoin_main.cpp. That file may or may not overwrite globals in the link stage depending on the link order. This is confusing and useless anyway: The unit tests should never std::exit in the middle of the run (especially with success as exit code), since it will skip all test modules afterward.
Also include a commit to remove some unused forward declarations and move the main_tests to validation_tests, since main was long ago split into net_processing and validation.
practicalswift
commented at 7:58 PM on February 28, 2019:
contributor
Concept ACK
Nice cleanup: -242 lines of code
test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADDfab2daa026
#14464 (refactor: make checkqueue manage the threads by itself (also removed some boost dependencies) by ken2812221)
#10102 ([experimental] Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake added the label Tests on Feb 28, 2019
MarcoFalke renamed this: test: Remove useless test_bitcoin_main.cpp fuzz: Link BasicTestingSetup (shared with unit tests) on Mar 6, 2019
ryanofsky approved
ryanofsky
commented at 7:43 PM on March 6, 2019:
contributor
utACKfaa9b88199c382c04e3aaa2b63479f9066ce8f9c. Looks good, bunch of nice simple make & test cleanups.
MarcoFalke referenced this in commit df36ddf9ce on Mar 6, 2019
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC