No description provided.
Better to read #15375
pull lucaslopes wants to merge 1 commits into bitcoin:master from lucaslopes:patch-1 changing 1 files +19 −15-
lucaslopes commented at 1:52 PM on February 9, 2019: none
-
Better to read e97e7940fc
-
gmaxwell commented at 10:31 PM on February 9, 2019: contributor
NAK. Separating descriptions of parameters from their descriptions does not make things more readable, and the 'footnote' style is non-idiomatic for this codebase or any other C++ codebase that I've seen lately.
-
Empact commented at 10:33 PM on February 9, 2019: member
NACK this removes doxygen comments, and distances comments from their relevant context.
You might want to turn your attention to changes that provide test-confirmable improvements, which are more likely to have concrete benefits. The contributing guide discourages refactoring changes for new developers for that reason, see #11276:
Pull requests that refactor the code should not be made by new contributors. It requires a certain level of experience to know where the code belongs to and to understand the full ramification (including rebase effort of open pull requests). https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring
- fanquake closed this on Feb 9, 2019
- lucaslopes deleted the branch on Feb 9, 2019
- bitcoin locked this on Feb 16, 2019
