gui: crash if encrypt / change passphrase window is open and wallet is unloaded #15310

1. 
   fanquake commented at 7:21 AM on February 1, 2019: member

   Using master @ cb35f1d305d88934df64c2e7fb80700b673360e6

   Run bitcoin-qt, and open either the Encrypt Wallet or Change Passphrase window. Unload the wallet. ie src/bitcoin-cli unloadwallet

   * thread [#1](/github-metadata-backup-bitcoin-bitcoin/1/), queue = 'com.apple.main-thread', stop reason = signal SIGABRT
     * frame [#0](/github-metadata-backup-bitcoin-bitcoin/0/): 0x00007fff5ba9523e libsystem_kernel.dylib`__pthread_kill + 10
       frame [#1](/github-metadata-backup-bitcoin-bitcoin/1/): 0x00007fff5bb4bc1c libsystem_pthread.dylib`pthread_kill + 285
       frame [#2](/github-metadata-backup-bitcoin-bitcoin/2/): 0x00007fff5b9fe1c9 libsystem_c.dylib`abort + 127
       frame [#3](/github-metadata-backup-bitcoin-bitcoin/3/): 0x00007fff5bb0d6e2 libsystem_malloc.dylib`malloc_vreport + 545
       frame [#4](/github-metadata-backup-bitcoin-bitcoin/4/): 0x00007fff5bb0d4a3 libsystem_malloc.dylib`malloc_report + 152
       frame [#5](/github-metadata-backup-bitcoin-bitcoin/5/): 0x0000000101ef9e90 QtCore`QObjectPrivate::deleteChildren() + 224
       frame [#6](/github-metadata-backup-bitcoin-bitcoin/6/): 0x00000001012439e2 QtWidgets`QWidget::~QWidget() + 1058
       frame [#7](/github-metadata-backup-bitcoin-bitcoin/7/): 0x00000001000ddc8c bitcoin-qt`WalletView::~WalletView() [inlined] WalletView::~WalletView(this=0x0000000159d976e0) at walletview.cpp:87 [opt]
       frame [#8](/github-metadata-backup-bitcoin-bitcoin/8/): 0x00000001000ddc87 bitcoin-qt`WalletView::~WalletView() [inlined] WalletView::~WalletView(this=0x0000000159d976e0) at walletview.cpp:86 [opt]
       frame [#9](/github-metadata-backup-bitcoin-bitcoin/9/): 0x00000001000ddc87 bitcoin-qt`WalletView::~WalletView(this=0x0000000159d976e0) at walletview.cpp:86 [opt]
       frame [#10](/github-metadata-backup-bitcoin-bitcoin/10/): 0x00000001000d42f8 bitcoin-qt`WalletFrame::removeWallet(this=0x000000010eaa4130, wallet_model=<unavailable>) at walletframe.cpp:98 [opt]
       frame [#11](/github-metadata-backup-bitcoin-bitcoin/11/): 0x000000010001f5b6 bitcoin-qt`BitcoinGUI::removeWallet(this=0x0000000108dc8bb0, walletModel=<unavailable>) at bitcoingui.cpp:611 [opt]
       frame [#12](/github-metadata-backup-bitcoin-bitcoin/12/): 0x0000000101f01d7b QtCore`QMetaObject::activate(QObject*, int, int, void**) + 2219
       frame [#13](/github-metadata-backup-bitcoin-bitcoin/13/): 0x00000001000ef3ff bitcoin-qt`WalletController::walletRemoved(this=<unavailable>, _t1=<unavailable>) at moc_walletcontroller.cpp:206 [opt]
       frame [#14](/github-metadata-backup-bitcoin-bitcoin/14/): 0x00000001000d2f46 bitcoin-qt`WalletController::removeAndDeleteWallet(this=0x0000000159d31a00, wallet_model=0x0000000122f44f80) at walletcontroller.cpp:91 [opt]
       frame [#15](/github-metadata-backup-bitcoin-bitcoin/15/): 0x0000000101f01d7b QtCore`QMetaObject::activate(QObject*, int, int, void**) + 2219
       frame [#16](/github-metadata-backup-bitcoin-bitcoin/16/): 0x0000000101efa801 QtCore`QObject::event(QEvent*) + 753
       frame [#17](/github-metadata-backup-bitcoin-bitcoin/17/): 0x0000000101218f8d QtWidgets`QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
       frame [#18](/github-metadata-backup-bitcoin-bitcoin/18/): 0x000000010121a392 QtWidgets`QApplication::notify(QObject*, QEvent*) + 594
   

2. fanquake added the label GUI on Feb 1, 2019
3. jonasschnelli cross-referenced this on Feb 1, 2019 from issue Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli
4. 
   jonasschnelli commented at 8:42 AM on February 1, 2019: contributor

   This is due to the blocking (synchronous) QDialog::exec() call which does not work with unloading wallets (from another thread at least).

   There are other areas where unloading a wallet via RPC will make the GUI crash (CoinControl / AddressBook, Transaction-Details, Unlocking a wallet, changing passphrase)

5. 
   gmaxwell commented at 11:28 PM on March 16, 2019: contributor

   User exposed easily triggered crasher, should probably block v0.18. :( Esp if users trigger this during/shortly after IBD they'll likely corrupt their blockchain state and end up with a days long resync or reindex.

   We might want to consider reverting #14941 just in 0.18.0, in part because there might be other similar interactions? (also because we're awfully close to 0.18 to engage in non-trivial fixes)

6. 
   jonasschnelli commented at 3:26 PM on March 17, 2019: contributor

   This is fixed in #15313 and I think it's a simple and ready fix that could merged into 0.18.

7. MarcoFalke added this to the milestone 0.18.0 on Mar 17, 2019
8. 
   promag commented at 9:30 PM on March 17, 2019: member

   This is due to the blocking (synchronous) QDialog::exec() call which does not work with unloading wallets (from another thread at least).

   There are other areas where unloading a wallet via RPC will make the GUI crash (CoinControl / AddressBook, Transaction-Details, Unlocking a wallet, changing passphrase)

   I've tried to remove all usages of QDialog::exec but the change is not that simple, especially in WalletModel::bumpFee.

   #15614 is an alternative solution which I think is more adequate for 0.18 branch.

9. MarcoFalke cross-referenced this on Mar 21, 2019 from issue gui: Defer removeAndDeleteWallet when no modal widget is active by promag
10. jonasschnelli closed this on Mar 22, 2019

    ---

11. jonasschnelli referenced this in commit abd914ed34 on Mar 22, 2019
12. promag cross-referenced this on Sep 16, 2019 from issue gui: Add Open External Wallet action by promag
13. promag cross-referenced this on Oct 15, 2019 from issue GUI unresponsive during slow operations by ryanofsky
14. PastaPastaPasta referenced this in commit 7017bc4620 on Sep 21, 2021
15. PastaPastaPasta referenced this in commit 167363d4bd on Sep 24, 2021
16. kwvg referenced this in commit 4094e3313e on Oct 12, 2021
17. bitcoin locked this on Dec 16, 2021
18. gades referenced this in commit de5ffa5cb1 on May 10, 2022

Contributors

fanquakejonasschnelligmaxwellpromag

Milestone
0.18.0