These are planning-ahead changes to make future upgrades smoother. See https://gist.github.com/2355445 for full reasoning.
The two changes in this pull are:
wrap lines
This reverts commit 7b90edb5a6cada7176012d09d748847b5f966585.
ACK changes
However, I think the gist link makes the hard fork process seem easier, more seamless and less damaging than it really is.
::addUnchecked()'s only caller already takes the necessary lock,
and has already calculated the TX's hash.
Fix remaining compile warnings.
This PULL reworks new (post-0.6.*) features of the
gettransaction/getblock RPC calls as follows:
It removes the 'decompositions' object argument from getblock,
replacing it just a list of transaction hashes; equivalent
(I believe) of passing the {"tx":"hash"} decomposition.
It replaces the 'decompositions' object argument of
gettransaction with a boolean flag; if true, returns
the same stuff that the {"script":"obj"} decomposition
would return (txins/txouts as hex, disassembled, and bitcoin
addresses).
It adds a "rawtx" field to the output of gettransaction,
that is the entire transaction serialized and hex-encoded.
It removes the "size" field from gettransaction, since the size
is trivial to compute from the "rawtx" field (either take the
length after hex-decoding, or just compute it as hex-length/2).
Minor refactor to support signrawtx signing/verifying transactions
when it might only have the previous transaction's txid and
txOut.
Implement listunspent / getrawtransaction / createrawtransaction /
signrawtransaction, to support creation and
signing-on-multiple-device multisignature transactions.
Remove duplicate GetHash() in ConnectBlock
Fixes #1373
Show block timestamp
1629 | + ++nUpgraded; 1630 | + pindex = pindex->pprev; 1631 | + } 1632 | + if (nUpgraded > 0) 1633 | + printf("SetBestChain: %d of last 100 blocks above version %d\n", nUpgraded, CBlock::CURRENT_VERSION); 1634 | + if (nUpgraded > 100/2)
Why not "50"?
Adds CBlock::CURRENT_VERSION and CTransaction::CURRENT_VERSION
constants, and makes non-CURRENT_VERSION transactions nonstandard.
This will help make future upgrades smoother.
This adds a warning "this version is obsolete, upgrade required" if
more than 50 of the previous 100 blocks in the blockchain are
a new version.